Avoid unnecessary allocations for empty strings

jekyll / jekyll-avatar

A Jekyll plugin for rendering GitHub avatars

MIT License

89 stars 9 forks source link

Closed ashmaroli closed 5 years ago

ashmaroli commented 5 years ago

Instead of coercing the env-var into a String, let us simply check if it is a non-empty String.

Every call to #render allocates 5 new "" just to check if it is empty:

#host is called at least 5 times per call to #render via #url.
when ENV["PAGES_AVATARS_URL"] == nil, every call to ENV["PAGES_AVATARS_URL"].to_s allocates memory for a new "".

benbalter commented 5 years ago

Thanks @ashmaroli!

ashmaroli commented 5 years ago

You're welcome :smiley: