search

jekyll / jekyll-avatar

A Jekyll plugin for rendering GitHub avatars
MIT License
89 stars 9 forks source link

Plugin no longer works correctly with Jekyll 4.x #59

Closed kusma closed 2 years ago

kusma commented 2 years ago

The changes to the template rendering in Jekyll 4 seems to have broken rendering of avatars in templates that use usernames from front-matter in pages.

Reproduction case

https://github.com/kusma/jekyll-avatar-issue-37-repro

Expected behavior:

foo.html gets the foo avatar rendered, and bar.html gets the bar avatar rendered.

Actual behavor:

foo.html gets the avatar from bar.html instead.

(split out from #37)

ashmaroli commented 2 years ago

@kusma This is not reproducible on the default branch of this repository. So, the fix will be included in the next release. If you're not deploying via GH Pages, you may point your Gemfile to this repository until we ship a release:

# in Gemfile

gem "jekyll-avatar", github: "jekyll/jekyll-avatar"

P.S. I'll close this when a new release has been shipped.

MolotovCherry commented 2 years ago

This was driving me up the wall! That fixed it completely, thanks!

ashmaroli commented 2 years ago

Hi, v0.8.0 has been released. Please upgrade and confirm if this issue has been resolved. Thanks.

kusma commented 2 years ago

I'm no longer using Jekyll, and as such no longer this plugin. But it should be possible to test using the repro repo for anyone...

ashmaroli commented 2 years ago

Thank you for responding to my call nevertheless.

MolotovCherry commented 2 years ago

I was using the one on master before which fixed this, and it was definitely confirmed. I haven't upgraded yet, but I don't see why the upgrade would be any different than what was on master

kusma commented 2 years ago

That's probably a good enough reason to close this, then!