search

jekyll / jekyll-coffeescript

A CoffeeScript converter for Jekyll.
MIT License
53 stars 20 forks source link

Circular dependence with jekyll:2.5.3 #34

Closed pinikeizman closed 5 years ago

pinikeizman commented 5 years ago

Hi, we are using jekyll:2.5.3 on some legacy doc static site and we encountered a circular dependence while installing jekyll:2.5.3 This is due to this file changed yesterday: https://github.com/jekyll/jekyll-coffeescript/blob/b2322d7020905eefff1eb795bd1cf20c2c5ab161/Gemfile#L6 If we could evaluate this if statement to false I think this will fix the circular dependence issue, but it will always evaluate to true because ruby can't eval string to false in if statement. Would you mind to enhance this code so we could evaluate it to false some how? Maybe check for "false" string and skip the gem command.

ashmaroli commented 5 years ago

That change affects only the development of jekyll-coffeescript not its usage. Is the legacy site available as a public repository?

pinikeizman commented 5 years ago

Thanks for the quick reply, the repo is public and can be viewed here: https://github.com/bigpandaio/docs.bigpanda.io I'm new to ruby so I might be wrong, but the build worked 2 days ago and it fails now. image

ashmaroli commented 5 years ago

Actually, you're right. Jekyll 2.5.3 has jekyll-coffeescript as a runtime_dependency which now has jekyll as a runtime_dependency as well. I'll push a new version a.s.a.p.

pinikeizman commented 5 years ago

Thanks! https://github.com/jekyll/jekyll-coffeescript/blob/b2322d7020905eefff1eb795bd1cf20c2c5ab161/jekyll-coffeescript.gemspec#L23 That might be the dependence added.

ashmaroli commented 5 years ago

I've pushed a new version. This should be resolved now. Please check and close. Thank you for reporting.

pinikeizman commented 5 years ago

Thanks, the issue has been fixed.