jekyll / jekyll-feed

:memo: A Jekyll plugin to generate an Atom (RSS-like) feed of your Jekyll posts
MIT License
827 stars 201 forks source link

Feed_meta Tag Doesn't Populate All Feeds #334

Closed adamsdesk closed 2 years ago

adamsdesk commented 3 years ago

When I use {% feed_meta %} I noticed that it only populates my posts collection feed. I have 3 other collections setup and they are never populated. Indeed the feed files are generated within the "/feed/" directory as configured.

Am I missing something? I don't see anything referring to this in the documentation on how to enable it for other collections.

I have the following jekyll-feed configuration in _config.yml as follows.

feed:
    path: /feed/blog.xml
    posts_limit: 50
    collections:
        - adamsdesk
        - mindfulsations
        - sfa
ashmaroli commented 3 years ago

@thewarden Thank you for reporting this. You're right. The tag doesn't render links to collection feeds indeed.

We'll try and address this very soon.

adamsdesk commented 3 years ago

Thank you and thanks for working so hard. I really appreciate it.

bencomp commented 3 years ago

I was just wondering whether it is possible to specify which feed the feed_meta tag should render when I found this issue.

My use case is a collection of events; I would like to include just the events feed on the events pages. Is that compatible with your use case, @thewarden? Or should I create a separate issue for this? (I understand if this is outside the scope of the project.)

adamsdesk commented 3 years ago

Yeah this would be a separate issue. As far as I know that presently this is not possible as it defaults to use the posts collections.

jekyllbot commented 3 years ago

This issue has been automatically marked as stale because it has not been commented on for at least two months.

The resources of the Jekyll team are limited, and so we are asking for your help.

If this is a bug and you can still reproduce this error on the master branch, please reply with all of the information you have about it in order to keep the issue open.

If this is a feature request, please consider whether it can be accomplished in another way. If it cannot, please elaborate on why it is core to this project and why you feel more than 80% of users would find this beneficial.

This issue will automatically be closed in two months if no further activity occurs. Thank you for all your contributions.

parkr commented 3 years ago

Changing how {% feed_meta %} works today may be surprising to users. The proposal to add a parameter (one of which could be "all" for all feed links) could offer a path to a solution. What do you think?

adamsdesk commented 3 years ago

I would sooner see it implemented in _config.yml. If you list the collection it should be included in the feed. It would be nice to add an option to state separated feed per collection or a single feed for all collections. If implementing separated feeds the path setting would need to be altered.

jekyllbot commented 3 years ago

This issue has been automatically marked as stale because it has not been commented on for at least two months.

The resources of the Jekyll team are limited, and so we are asking for your help.

If this is a bug and you can still reproduce this error on the master branch, please reply with all of the information you have about it in order to keep the issue open.

If this is a feature request, please consider whether it can be accomplished in another way. If it cannot, please elaborate on why it is core to this project and why you feel more than 80% of users would find this beneficial.

This issue will automatically be closed in two months if no further activity occurs. Thank you for all your contributions.

bencomp commented 2 years ago

After having another look at this issue, just before it's closed, I wonder: are there two issues at play here?

Strictly speaking, the feed_meta tag only handles the generation of a <link/> to the feed. Adding collections, maybe categories as well, to the _config.yml is how we say which items should go in a feed, but the feed_meta tag isn't involved. I agree that it may be confusing to not see links to all the feeds – hence #335.

But there are two potential solutions: let feed_meta output a link for each feed, or include all items in one feed and let feed_meta output a link to that feed. The latter feels like a different kind of issue.

The former brings up the question what the relationship is between the HTML and the Atom feed. The <link rel="alternate" ../> says that the feed URI Refers to a substitute for this context in the IANA Link Relations overview. I would say that not all feeds are actual substitutes of the HTML they are linked from, so I would not want to put links to all feeds in every page. However, the WHATWG living HTML spec says that for Atom and RSS feeds there need not be a one-to-one relationship to aid feed discovery, so it wouldn't be a problem according to them. Maybe, even if it may surprise many users, outputting links to all feeds is a good solution after all?

ashmaroli commented 2 years ago

My take on this is that having the feed_meta tag output multiple meta tags is going to be problematic and the best route (from the perspective of both implementation and flexibility of usage) is to resolve #335 instead: Provide (a) parameter(s) and let users decide what meta tags need to be rendered for a particular page.

jekyllbot commented 2 years ago

This issue has been automatically marked as stale because it has not been commented on for at least two months.

The resources of the Jekyll team are limited, and so we are asking for your help.

If this is a bug and you can still reproduce this error on the master branch, please reply with all of the information you have about it in order to keep the issue open.

If this is a feature request, please consider whether it can be accomplished in another way. If it cannot, please elaborate on why it is core to this project and why you feel more than 80% of users would find this beneficial.

This issue will automatically be closed in two months if no further activity occurs. Thank you for all your contributions.