search

jekyll / jekyll-feed

:memo: A Jekyll plugin to generate an Atom (RSS-like) feed of your Jekyll posts
MIT License
848 stars 206 forks source link

Allow `categories: true` to make feeds for all categories #379

Open jez opened 1 year ago

jez commented 1 year ago

Motivation

Fixes #361

Summary

This change behaves like how tags: true works, and like how @parkr suggested in the comments of #361.

If there's anything you'd like changed in the implementation, please let me know.

Test plan

I've written a test case for this and also verified that it works for my personal blog when I pass categories: true in my feed: settings.

jez commented 1 year ago

(This is based on the fixed master commit now)

jez commented 1 year ago

Sorry about that, I didn’t realize that rubocop was set up for the repo, and I had forgotten to run that locally.

I fixed the rubocop errors by factoring out my changes to a new method. Feel free to suggest any tweaks as you wish.

ashmaroli commented 1 year ago

Hello @jez, you needn't apologize for overlooking RuboCop offenses. It's part of the process.

~~Anyways, I'm finding the use of param name meta confusing now that the logic has been abstracted to a separate definition. How about using collection itself~~

Edit: I read the code wrong.

jez commented 1 year ago

@ashmaroli I saw you crossed out your request–is there anything else you'd like me to change about this PR?

(otherwise, I think this change is ready to go)

jez commented 1 year ago

@ashmaroli friendly bump!

ashmaroli commented 1 year ago

Thanks for the ping, @jez. This had fallen off my radar.