jekyll / jekyll-import

:inbox_tray: The "jekyll import" command for importing from various blogs to Jekyll format.
https://import.jekyllrb.com
MIT License
516 stars 316 forks source link

s9y-db importer permalink, tag, excerpt, and semantic HTML improvements #392

Closed judebert closed 3 years ago

judebert commented 5 years ago

These commits support plugins and properties required to migrate judebert.com from S9Y to Jekyll. The features include:

Documentation has been updated to describe the new functionality.

judebert commented 5 years ago

All PR comments addressed. script/cibuild passes on my computer.

ashmaroli commented 5 years ago

I still see the following in the diff:

if options[:clean_entities]
  options[:clean_entities] = require_if_available("htmlentities", "clean_entities") if options[:clean_entities]
end

if options[:markdown]
  options[:markdown] = require_if_available("reverse_markdown", "markdown") if options[:markdown]
end
judebert commented 5 years ago

Friendly ping: I think I pushed another update addressing all issues, about 3 weeks ago. Is there anything else I need to do to merge?

ashmaroli commented 5 years ago

addressing all issues, about 3 weeks ago.

Apologies, @judebert. This had slipped out of my head. Will post a fresh review shortly.

parkr commented 3 years ago

@jekyllbot: merge +minor