search

jekyll / jekyll-import

:inbox_tray: The "jekyll import" command for importing from various blogs to Jekyll format.
https://import.jekyllrb.com
MIT License
516 stars 316 forks source link

Change data[author] to a string scalar #419

Closed isotopp closed 3 years ago

isotopp commented 5 years ago

Using the minima template, data[author] is supposed to be a string scala, but the conversion turns it into a map of displayname, author_login and author_email. author_login and author_email are also stored as separate scalar attributes. The fix turns data[author] into a string scalar field of displayname, fixing the display of the author name in the minima template.

parkr commented 5 years ago

There was a push to migrate away from the scalar author field and to a hash. I wonder how feasible that is, for example if it’s not backwards compatible then GitHub Pages can’t upgrade.

ashmaroli commented 5 years ago

if it’s not backwards compatible then GitHub Pages can’t upgrade

@parkr This plugin is not bundled with github-pages, but it is a "blessed gem" for Jekyll. Is that cause of your concern?

parkr commented 5 years ago

@ashmaroli I was more thinking about the minima gem!

ashmaroli commented 5 years ago

I was more thinking about the minima gem!

I see.. But Minima doesn't care about author in a document's front matter or data hash, just the author in the config file..

parkr commented 3 years ago

@jekyllbot: merge +fix