jekyll / jekyll-import

:inbox_tray: The "jekyll import" command for importing from various blogs to Jekyll format.
https://import.jekyllrb.com
MIT License
512 stars 315 forks source link

Escape non ascii-characters while image downlading from wordpress #531

Closed ahmetozer closed 9 months ago

ahmetozer commented 9 months ago

While importing one of the Turkish websites, I noticed ruby HTTP library was not able to download because of the non-ASCII characters.

So I used escape while download process.

An example command

ruby -r rubygems -e 'require "jekyll-import";JekyllImport::Importers::WordpressDotCom.run({"source" => "wordpress.xml","no_fetch_images" => false, "assets_folder" => "assets" })'
mattr- commented 9 months ago

Thanks for contributing! :heart:

Could you address the comment from the code style check action and update your PR? I'll be happy to merge it after that.

ahmetozer commented 9 months ago

Hello @parkr and @mattr- thank you for reviewing, do I need to do anything? I am not familiar with this programming language, but if it's a must for this repo I can take a look at the test part. Thanks 😊

parkr commented 9 months ago

@jekyllbot: merge +fix