search

jekyll / jekyll-paginate

NO LONGER UNDER ACTIVE DEVELOPMENT as of Jekyll 3: Pagination Generator for Jekyll
MIT License
111 stars 84 forks source link

Apply Rubocop fixes #47

Closed parkr closed 2 years ago

parkr commented 2 years ago

Each cop is addressed in its own commit.

ashmaroli commented 2 years ago

@parkr Is this repo back in maintenance? Regardless, The CI check is failing because even though rubocop-jekyll has been added to the bundle in a prior commit, you forgot to add a .rubocop.yml and load the RuboCop extension.

parkr commented 2 years ago

@ashmaroli I get dependabot alerts from GitHub and the jekyll-paginate one was bugging me so that's why I updated the gemspec. Easy enough– it's a dev dependency. I added CI back in to test it and the CI workflow I copied was from jekyll-seo-tag which includes Rubocop. I am not opposed to making the rest of these style updates and merging them in, though I'm concerned we might introduce a bug by accident so the alternative is to remove the Rubocop checks from CI 😄

ashmaroli commented 2 years ago

I get dependabot alerts from GitHub and the jekyll-paginate one was bugging me so that's why I updated the gemspec...

Oh yeah, I get those too. But I just ignore them. Since that was the sole motivation behind recent commit(s), I don't see the point in further investing time in this.