search

jekyll / jekyll-redirect-from

:twisted_rightwards_arrows: Seamlessly specify multiple redirections URLs for your pages and posts.
MIT License
782 stars 114 forks source link

Inherit Jekyll's rubocop config for consistency #117

Closed DirtyF closed 7 years ago

DirtyF commented 8 years ago

This PR is the result of adding inherit_gem:\n jekyll: .rubocop.yml to .rubocop.yml and running rubocop -a so that this project follows Jekyll core's coding styles for consistency like other core plugins. This way, as Jekyll's Ruby style changes, so too will this project's.

benbalter commented 8 years ago

Ha. I'm starting to see a trend... Nice!

pathawks commented 8 years ago

Technically, technically, I think we'll want to alias the old versions of these to avoid a breaking change, since these were public methods (although I don't know how/why you'd use them).

Yes, I think we need to assume that anything not private is being twiddled in someway somewhere. All the more reason to make new methods private by default.

Do we want to create an alias, or just exclude from Rubocop until next major version?

benbalter commented 8 years ago

Do we want to create an alias, or just exclude from Rubocop until next major version? Hide all checks

Not strongly opinionated... I suspect we won't remember to rename the methods before a major release, but would be more likely to remember to remove aliases since they look out of place.

parkr commented 8 years ago

Definitely need to maintain compatibility. Does rubocop complain about the aliases too though? Having bad names.

DirtyF commented 8 years ago

@parkr Rubocop doesn't complain about aliases.

benbalter commented 7 years ago

Thanks @DirtyF! This was included in (and was the impetus for) https://github.com/jekyll/jekyll-redirect-from/pull/131.