search

jekyll / jekyll-redirect-from

:twisted_rightwards_arrows: Seamlessly specify multiple redirections URLs for your pages and posts.
MIT License
780 stars 112 forks source link

Avoid documents cache problem #205

Closed radoslavkarlik closed 5 years ago

radoslavkarlik commented 5 years ago

Fixes the #199

ashmaroli commented 5 years ago

To be honest, I'm not sure what the best route is here.. revert the caching upstream or accept this patch here...

Shipping this patch will solve the problem for Jekyll 3.8.x but.. I've already implemented caching for site.documents as well for Jekyll 4.0

@RadoslavK Will you be able run your set up with the proposed patch here and jekyll-4.0.0.pre.alpha1? If your local tests pass satisfactorily, this PR can be shipped, otherwise we may need to revert the caching at Jekyll itself.

mattr- commented 5 years ago

This is painful, but I'd rather see us revert the caching mechanism we added to Jekyll. It doesn't make sense to me to make plugins workaround problems we've introduced in the core.

parkr commented 5 years ago

I think removing the docs_to_write cache is the better move, but it requires a Jekyll update. I'm happy to do this as well to unblock folks.

ashmaroli commented 5 years ago

@parkr I volunteer to provide you with assistance. Should I submit a PR to Jekyll's 3.8.stable branch?

DirtyF commented 5 years ago

@RadoslavK This will be fixed upstream in Jekyll core, thanks for reporting.