jekyll / jekyll-redirect-from

:twisted_rightwards_arrows: Seamlessly specify multiple redirections URLs for your pages and posts.

MIT License

789 stars 116 forks source link

Refactor specs for RedirectPage #222

Closed satyanash closed 4 years ago

satyanash commented 4 years ago

I was planning to take a crack at #214 and realized that the specs for RedirectPage could do with some refactoring before actually implementing the fix for it. Would like to get the refactor merged before moving on to the actual fix.

At a high level the refactor does the following:

Extract common code into an rspec shared_examples block.
Stop using RedirectPage.from_paths in the spec. ~and makes it private~.
Only use RedirectPage.redirect_from and RedirectPage.redirect_to in the spec.
Split the specs into two high level contexts for each of the two public class methods.

satyanash commented 4 years ago

Current failures are on JEKYLL_VERSION="~> 3.8" due to kramdown-parser-gfm being unavailable in jekyll 3.9 Have submitted another fix for this in #223 to lock JEKYLL_VERISON='~> 3.8.0'.

satyanash commented 4 years ago

223 is closed in favour of #224

satyanash commented 4 years ago

All CI checks are now passing for this refactor.

satyanash commented 4 years ago

@ashmaroli May I know what is blocking the merge for this PR? I'm unable to find a user called @jekyll/plugin-core

ashmaroli commented 4 years ago

@jekyll/plugin-core is a ping to a team of members within the Jekyll organization on GitHub that maintain plugins under the Org. You may not see details if you don't have sufficient privileges.

Either ways, this is going to wait for couple of days for a response from the team. You're welcome to start work on a new branch created off this branch and then rebase once this gets merged into master.

ashmaroli commented 4 years ago

Thanks @satyanash @jekyllbot: merge +dev