jekyll / jekyll-seo-tag

A Jekyll plugin to add metadata tags for search engines and social networks to better index and display your site's content.
https://jekyll.github.io/jekyll-seo-tag
MIT License
1.66k stars 294 forks source link

Change <meta property="twitter:image" ...> to <meta name="twitter:image" ...> #465

Closed hannotify closed 1 year ago

hannotify commented 2 years ago

It seems like Twitter Cards has moved away from detecting <meta property="twitter:image" ...>, because I noticed that the images I provided to my blog posts stopped showing up in my Twitter Cards. This StackOverflow answer caused me to look into the issue and sure enough, the Twitter documentation now uses meta name instead of meta property.

When I tried to verify this using the following dirty hack...

    {% capture seoWithProperTwitterMetaTags %}
    {% seo %}
    {% endcapture %}

    <!-- because of https://stackoverflow.com/a/71063178/505996 -->
    {{ seoWithProperTwitterMetaTags | replace: 'property="twitter:image"', 'name="twitter:image"' }}

...it turned out this was actually the issue, because the images started showing up on my Twitter Cards again.

So I want to suggest to change <meta property="twitter:image" ...> to <meta name="twitter:image" ...>.

jekyllbot commented 2 years ago

This issue has been automatically marked as stale because it has not been commented on for at least two months.

The resources of the Jekyll team are limited, and so we are asking for your help.

If this is a bug and you can still reproduce this error on the master/main branch, please reply with all of the information you have about it in order to keep the issue open.

If this is a feature request, please consider whether it can be accomplished in another way. If it cannot, please elaborate on why it is core to this project and why you feel more than 80% of users would find this beneficial.

This issue will automatically be closed in two months if no further activity occurs. Thank you for all your contributions.