search

jekyll / jekyll-seo-tag

A Jekyll plugin to add metadata tags for search engines and social networks to better index and display your site's content.
https://jekyll.github.io/jekyll-seo-tag
MIT License
1.66k stars 294 forks source link

Make the meta generator tag optional #481

Open melroy89 opened 1 year ago

melroy89 commented 1 year ago

Webmasters are able to decide themselves whether they want to include a generate meta HTML tag or not.. seo_tag.skip_generator.

ashmaroli commented 1 year ago

Prior art: #404

ashmaroli commented 1 year ago

@danger89 We, the maintainers, have not reached at a consensus on whether the meta tag ought to be removed completely or rendered conditionally. Regardless, I'd like to leave one comment as feedback to this pull request: How exactly are webmasters supposed to opt to render / not render the meta tag? They do not have control over the seotag object from their config file. You have not included any documentation / integration-test to demonstrate usage.

melroy89 commented 1 year ago

https://github.com/jekyll/jekyll-seo-tag/pull/404

Is not applying review comments anymore. I applied the patch correctly.

melroy89 commented 1 year ago

@danger89 How exactly are webmasters supposed to opt to render / not render the meta tag? They do not have control over the seotag object from their config file.

Well I think we have control over this. A bit similar to the title (which is also using the seo tag):

https://github.com/jekyll/jekyll-seo-tag/blob/master/docs/advanced-usage.md#disabling-title-output

You have not included any documentation / integration-test to demonstrate usage.

Agreed. I can add that for sure! Hopefully you all find consensus in the meanwhile.

ashmaroli commented 1 year ago

A bit similar to the title (which is also using the seo tag).

@danger89 I'm aware of the connection of "title" with {{ seo_tag }}. But have you tested the proposed implementation at your end? (My previous comment was with respect to then current state of this pull request branch).

melroy89 commented 1 year ago

I will test it soon. And also create the required integration tests as well as user documentation.

pegvin commented 7 months ago

I have no clue why this isn't merged yet, it doesn't break anything, and it's a good feature.

melroy89 commented 7 months ago

I have no clue why this isn't merged yet, it doesn't break anything, and it's a good feature that.

Agreed. It's a simple but effective change.

pegvin commented 6 months ago

I found a simple fix to this, I just switched to @lumeland, it's far better and faster than jekyll and community support is pretty alive too.

melroy89 commented 6 months ago

I found a simple fix to this, I just switched to @lumeland, it's far better and faster than jekyll and community support is pretty alive too.

That is just a weird statement. Just because of this small missing optional meta tag generator? You have still full control over your plugins with Jekyll just like with Hugo. In all cases you can clone the code and made changes yourself, you are in full control how you want to use it or even extend it to your own liking. That being said, I do wish they just merge these PRs, so I don't need to maintain my own fork.

I still need to write an integration test tho..