search

jekyll / jekyll-sitemap

Jekyll plugin to silently generate a sitemaps.org compliant sitemap for your Jekyll site
http://rubygems.org/gems/jekyll-sitemap
MIT License
961 stars 135 forks source link

Docs: set site.url in config #172

Closed jakob-stoeck closed 6 years ago

jakob-stoeck commented 7 years ago

fix #171 #156

benbalter commented 7 years ago

Thanks @jakob-stoeck! Can you describe what problem you're trying to solve?

If it's that you need to add site.url to your config, I'd call that a configuration, not an installation instruction, and optional, since hosted services like GitHub Pages will set that automatically.

jakob-stoeck commented 7 years ago

@benbalter Hi Ben, agreed. But since two of the six issues addressed this problem (#156, #171) it doesn’t seem to be obvious for everybody.

With a standard Jekyll installation the site.url parameter is empty and everything works fine because the URL is not used anywhere. That is until you install a plugin which uses it, like the sitemap one.

antgel commented 6 years ago

It would be great to see this merged. Apparently I'm not the only one that fell into this trap.

DirtyF commented 6 years ago

@jekyllbot: merge +docs