search

jekyll / jekyll-sitemap

Jekyll plugin to silently generate a sitemaps.org compliant sitemap for your Jekyll site
http://rubygems.org/gems/jekyll-sitemap
MIT License
961 stars 135 forks source link

Jekyll deprecation warning on `gems` key in config` #181

Closed tejasbubane closed 7 years ago

tejasbubane commented 7 years ago

Jekyll changed the gems key in _config.yml to plugins in v3.5.0: https://jekyllrb.com/news/2017/06/15/jekyll-3-5-0-released/

Readme suggests to add this plugin to gems section. Although that is just a deprecation warning and it is backwards compatible and still works, I think we should mention about this warning in the readme.

pathawks commented 7 years ago

Good call.

We should wait until GitHub Pages is using v3.5.0, but then I agree that we should mention this :+1:

tejasbubane commented 7 years ago

Now that github pages uses v3.5+: https://pages.github.com/versions/, we can make this change.