jekyll / jekyll-sitemap

Jekyll plugin to silently generate a sitemaps.org compliant sitemap for your Jekyll site
http://rubygems.org/gems/jekyll-sitemap
MIT License
961 stars 135 forks source link

Handling of absolute URLs #238

Closed mnlipp closed 5 years ago

mnlipp commented 5 years ago

The plugin does not handle absolute URLs as expected. The top level document on my site uses absolute URLs (https://mnlipp.github.io/project/...) to refer to the documentation of my projects. I would assume that this is "standard", because you edit this top level content in a "normal" github project (in my case https://github.com/mnlipp/mnlipp.github.com). While you do this, the ghpages-content of your projects is not available and relative links cannot be checked.

On github, of couse, the content of the mnlipp.github.com project and the ghpages from the other projects are "merged" into a single tree where the ghpages are in subdirectories with the projects' names. So eventually relative URLs could be used.

I have activated the jekyll-sitemap plugin and have found that it generates a sitemap with only the links in my top level page. These links are not crawled. I assume, because they are absolute URLs (start with https://...). However, I'd assume the plugin to be clever enough to find out that the URLs -- despite having the syntax of an absolute URL -- are effectively relative to the site being crawled and crawl them.

jekyllbot commented 5 years ago

This issue has been automatically marked as stale because it has not been commented on for at least two months.

The resources of the Jekyll team are limited, and so we are asking for your help.

If this is a bug and you can still reproduce this error on the master branch, please reply with all of the information you have about it in order to keep the issue open.

If this is a feature request, please consider whether it can be accomplished in another way. If it cannot, please elaborate on why it is core to this project and why you feel more than 80% of users would find this beneficial.

This issue will automatically be closed in two months if no further activity occurs. Thank you for all your contributions.