jekyll / jekyll-sitemap

Jekyll plugin to silently generate a sitemaps.org compliant sitemap for your Jekyll site
http://rubygems.org/gems/jekyll-sitemap
MIT License
949 stars 134 forks source link

How do you add custom files to the sitemap? XML files get ignored by default #252

Closed nickjj closed 4 years ago

nickjj commented 4 years ago

Hi,

I noticed that XML files are being ignored by default which means RSS feeds aren't being added to the sitemap.xml file that gets generated.

The documentation only mentions how to exclude paths.

How would you add custom files to be added to the generated sitemap?

The use case is I went to submit my podcast to Google Podcasts and they said my feed wasn't crawled by Google. So then I checked Google Webmaster Tools and yep, it wasn't crawled. Then I checked the sitemap generated by this plugin and my feed URLs weren't included. They are xml files located in various paths of my project.

I didn't dive too deep in the source but it seems that you don't include xml files in this variable: https://github.com/jekyll/jekyll-sitemap/blob/master/lib/jekyll/jekyll-sitemap.rb#L19

Is there a reason behind that?

jekyllbot commented 4 years ago

This issue has been automatically marked as stale because it has not been commented on for at least two months.

The resources of the Jekyll team are limited, and so we are asking for your help.

If this is a bug and you can still reproduce this error on the master branch, please reply with all of the information you have about it in order to keep the issue open.

If this is a feature request, please consider whether it can be accomplished in another way. If it cannot, please elaborate on why it is core to this project and why you feel more than 80% of users would find this beneficial.

This issue will automatically be closed in two months if no further activity occurs. Thank you for all your contributions.

nickjj commented 4 years ago

Any thoughts on this subject before I fork the project?

mattr- commented 4 years ago

Not including XML files seems like an oversight on our part. If you'd like to fork the project and submit a pull request, that would be awesome.

nickjj commented 4 years ago

Done. Thanks!