search

jekyll / jekyll-sitemap

Jekyll plugin to silently generate a sitemaps.org compliant sitemap for your Jekyll site
http://rubygems.org/gems/jekyll-sitemap
MIT License
949 stars 134 forks source link

Fix broken build for jekyll-sitemap #277

Closed kriation closed 3 years ago

kriation commented 3 years ago

A couple of months ago I noticed that the build failed for my PR #254 and I finally had the opportunity to dig into why.

In the v3.9 release of Jekyll, the kramdown dependency was changed to v2. In v2, the parsers were built into individual gems. Unfortunately, Jekyll 3.9.0 didn't include kramdown-parser-gfm as a dependency which was causing the build failure.

I took the opportunity to adjust the the travis definition to explicitly build against all of the versions that jekyll-sitemap supports (>= 3.7) and included a fix for the 3.9.0 build so that the kramdown-gfm-parser would be included.

The changes increased the number of jobs from four to eight improving the build coverage of the gem. The successful build result of all eight jobs is located here.

ashmaroli commented 3 years ago

For reference: Fixing CI builds in jekyll/jekyll-feed testing Jekyll 3.9.0

DirtyF commented 3 years ago

This has been fixed since thanks @kriation for bringing this to our attention.