Closed emmahsax closed 2 years ago
@parkr or @DirtyF or @ashmaroli
I've created this pull request to help move this repository from Travis CI to GitHub Actions. Can you please take a look when you have a chance?
I also don't know how to make my pull request trigger GitHub Actions workflows... that may be a setting in the repository, but they all passed on my fork's pull request except the Rubocop test.
@emmahsax Thank you for initiating the migration. The reason your workflow did not trigger a run on this repo is probably because of:
I have now pushed a workflow file to master
, to have GH Actions recognize pull requests from forks to this repo.
Please rebase your branch along with the following changes:
if: "!contains(github.event.commits[0].message, '[ci skip]')"
is no longer necessary. GH Actions have it built-in now.matrix.include
. Refer #291 for an example.3.0
needs to be quoted "3.0"
. So quote all entries.@ashmaroli Thank you for the response! I have made the suggestions you mentioned. I suppose I need approval to run workflows on this pull request, but then they should trigger 🤞🏼 .
Thank you!
@ashmaroli All right, the tests have all run and passed. This PR is ready for another review!
Thank you @emmahsax @jekyllbot: merge +dev
Switch from Travis CI to GitHub Actions. This will join a slow shift in Jekyll's projects from Travis CI to GitHub Actions.
I also prefer to use GitHub Actions because Travis CI (at least on travis-ci.com) is now charging money for users to use more than 10K credits.