jekyll / jekyll-sitemap

Jekyll plugin to silently generate a sitemaps.org compliant sitemap for your Jekyll site
http://rubygems.org/gems/jekyll-sitemap
MIT License
949 stars 134 forks source link

Allow generating sitemap_index files #300

Open ashmaroli opened 1 year ago

ashmaroli commented 1 year ago

Resolves #295 In order to link multiple sitemap files.

TODO: Add documentation once implementation is approved.

olifre commented 1 year ago

I tested this and it works perfectly well for me, an example configuration is shown e.g. at: https://github.com/olifre/olifre.github.io/commit/bff63b4214cb98551d64e36c9665ba7e3bd2d656 It does not seem to work with the standard Jekyll builder on GitHub, but that's probably since it seems to ignore selecting a specific branch. Works fine like a charm when testing it locally, including generation of appropriate robots.txt and allowing to change name of the index file.

Thanks! :+1:

ashmaroli commented 1 year ago

I tested this and it works perfectly well for me,

Thanks for testing, @olifre. Happy to know that the current implementation works for your use-case. However, I wouldn't recommend using in production until this gets reviewed / merged at minimum.

olifre commented 1 year ago

However, I wouldn't recommend using in production until this gets reviewed / merged at minimum.

Sure :smile:. I was just trying it out locally and checked whether it would work with GitHub Pages, the commit right after the one I linked reverts the changes and I am using a manual workaround (hand-crafted files) for the time being. Thanks again for the implementation!

MilesCranmer commented 1 year ago

Just pinging this – this is really useful, thanks again for submitting it. Could this be merged? (Who should we ping for a review?)

yannickwurm commented 1 year ago

bumping this