search

jekyll / jemoji

GitHub-flavored emoji plugin for Jekyll
http://rubygems.org/gems/jemoji
MIT License
557 stars 62 forks source link

Don't load Gemoji into memory immediately #106

Closed ashmaroli closed 4 years ago

ashmaroli commented 4 years ago

Jekyll loads all plugins at a very early stage in the build process. However, lib/emoji.rb doesn't directly reference any object initialized by the gemoji gem. The heavy-lifting is done by html-pipeline gem (which ultimately loads the gemoji library anyway, but it does so much later, after Jekyll's :post_render has been triggered).

For the curious, you may run the following script (via Bundler) to get an idea:

require 'memory_profiler'
MemoryProfiler.report { require 'gemoji' }.pretty_print(scale_bytes: true)
parkr commented 4 years ago

Looks like the gemoji library could use some frozen_string_literal: true directives!

mattr- commented 4 years ago

@jekyllbot: merge +minor

ashmaroli commented 4 years ago

Looks like the gemoji library could use some frozen_string_literal: true directives!

@parkr Took care of that months ago :wink: