jekyll / jemoji

GitHub-flavored emoji plugin for Jekyll
http://rubygems.org/gems/jemoji
MIT License
557 stars 62 forks source link

some emoji not supported #122

Closed casperdcl closed 1 year ago

casperdcl commented 2 years ago

is there a list of supported emoji? Some don't seem to work.

e.g.: :star_struck: renders fine in this issue, but not on https://tldr.cdcl.ml/prototype-fast:

GH issue (native) gh-pages site (jekyll/jemoji)
:star_struck: image
jekyllbot commented 1 year ago

This issue has been automatically marked as stale because it has not been commented on for at least two months.

The resources of the Jekyll team are limited, and so we are asking for your help.

If this is a bug and you can still reproduce this error on the master/main branch, please reply with all of the information you have about it in order to keep the issue open.

If this is a feature request, please consider whether it can be accomplished in another way. If it cannot, please elaborate on why it is core to this project and why you feel more than 80% of users would find this beneficial.

This issue will automatically be closed in two months if no further activity occurs. Thank you for all your contributions.

bewuethr commented 1 year ago

I see the same, using v0.12.0; within the same document:

bewuethr commented 1 year ago

I dug a bit further; jemoji depends on gemoji to perform the actual replacement of the emoji colon sequences:

https://github.com/jekyll/jemoji/blob/b6b4fa6a576df783943f07dd859ff26d81236440/jemoji.gemspec#L18

Now, the latest v3 release of gemoji is v3.0.1 from July 2019; commits to gemoji since then include

Specifically, the emoji.json file has received over 10k new lines and over 7k deletions (too large to show in web client).

What this means when using gemoji: you can't use any emoji added in 2018 or later in this chart. There are v4 release candidates of gemoji, but the most recent one is from January 2020. I'll play around a bit to see if gemoji is affected by the breaking changes or not, and if not, we can maybe lobby @mislav to release gemoji v4, and get jemoji to bump the dependency?

bewuethr commented 1 year ago

This being said, :star_struck: should work, it's part of Unicode 10.0 🤔 looks like they're not supported either, only 9 and older. We're stuck with emoji from 2016 and older 😱

mislav commented 1 year ago

Thanks for the ping; I've merged outstanding gemoji PRs and will release gemoji v4.0.0 final (with Unicode 14 support) after I've checked with my peers; probably tomorrow.

bewuethr commented 1 year ago

Thanks for the ping; I've merged outstanding gemoji PRs and will release gemoji v4.0.0 final (with Unicode 14 support) after I've checked with my peers; probably tomorrow.

Most excellent, thanks! I'll see if jemoji can be bumped then and will open a PR here if so.

bewuethr commented 1 year ago

...turns that's already in flight at #94

mislav commented 1 year ago

gemoji 4.0.0 is out 🚀

ashmaroli commented 1 year ago

Thank you for shipping v4.0.0 @mislav

parkr commented 1 year ago

jemoji v0.13.0 is out with gemoji v4 support 🤩

bewuethr commented 1 year ago

Amaaaazing! 🚀 Thank you all 😃 Off to emoji up my website...

casperdcl commented 1 year ago

Upgraded but :star_struck: still doesn't work for me

...
    jemoji (0.13.0)
      gemoji (>= 3, < 5)
...
bewuethr commented 1 year ago

Upgraded but :star_struck: still doesn't work for me

You still use gemoji 3.0.1 (see here), you have to update that to 4.0.0.

casperdcl commented 1 year ago

Ah I see why it wasn't updated

Bundler could not find compatible versions for gem "gemoji":
  In Gemfile:
    gemoji (~> 4.0)

    jekyll-spaceship was resolved to 0.10.2, which depends on
      gemoji (~> 3.0)