search

jekyll / jemoji

GitHub-flavored emoji plugin for Jekyll
http://rubygems.org/gems/jemoji
MIT License
556 stars 61 forks source link

Integration with amp #79

Closed xRahul closed 6 years ago

xRahul commented 6 years ago

Time to reopen amp integration. We have amp-jekyll now which gives amp-img conversion out of the box, but somehow jemoji built img tags are getting bypassed. This needs to get some priority as amp pages are gaining popularity.

pathawks commented 6 years ago

Isn’t this an issue with your Amp plugin? I wonder if it is being executed before this plugin converts emoji to images.

xRahul commented 6 years ago

Yes, I tried to check that, but I don't know ruby. Only the basics needed for Jekyll. If someone can check it out, that would be awesome. We already had a similar request coming a while back to add support for amp. This is a follow up on that.

jekyllbot commented 6 years ago

This issue has been automatically marked as stale because it has not been commented on for at least two months.

The resources of the Jekyll team are limited, and so we are asking for your help.

If this is a bug and you can still reproduce this error on the master branch, please reply with all of the information you have about it in order to keep the issue open.

If this is a feature request, please consider whether it can be accomplished in another way. If it cannot, please elaborate on why it is core to this project and why you feel more than 80% of users would find this beneficial.

This issue will automatically be closed in two months if no further activity occurs. Thank you for all your contributions.