search

jekyll / jemoji

GitHub-flavored emoji plugin for Jekyll
http://rubygems.org/gems/jemoji
MIT License
557 stars 62 forks source link

Test with Gemoji 4.0.x as well #94

Closed ashmaroli closed 1 year ago

ashmaroli commented 5 years ago

https://github.com/github/gemoji/releases/tag/v4.0.0.pre0

ashmaroli commented 5 years ago

IMO, this shouldn't be merged until gemoji-4.0.0 has been released..

trueheart78 commented 2 years ago

Gemoji v4 has been out for some time. I'd love to see this PR rebased and updated.

parkr commented 2 years ago

Looks like release candidate 3 is out, but not a finalized version yet. I wonder what they're waiting on. https://rubygems.org/gems/gemoji

parkr commented 2 years ago

Filed a request: https://github.com/github/gemoji/issues/213

bewuethr commented 1 year ago

gemoji 4.0.0 has been released today 😃

ashmaroli commented 1 year ago

@bewuethr Thanks for letting us know. Before proceeding, this repository needs to set up CI via GitHub Actions first.

parkr commented 1 year ago

Adding Actions CI workflow in #127

parkr commented 1 year ago

I did a naïve test of gemoji v4 and it passes: https://github.com/jekyll/jemoji/pull/129. We should support v3 and v4 for now so users can downgrade if they don't like v4. Dependabot has already proposed this in #131 so we could extend that with the CI changes.

parkr commented 1 year ago

This is taken care of in #131. There's some optimization for our CI now (there are 8 actions since the matrix is 2x2x2) but otherwise we're ready to go! We can release a v0.13.0 or a v1.0.0 which allow gemoji v3 and v4.