search

jekyll / minima

Minima is a one-size-fits-all Jekyll theme for writers.
https://jekyll.github.io/minima/
MIT License
3.44k stars 3.62k forks source link

Improve Accessibility of Social Media Links #257

Open austinseraphin opened 6 years ago

austinseraphin commented 6 years ago

The links to external sites such as Twitter require a text label. Currently the links have the local site's title instead of the external site's title. For example, the Twitter link should read "Twitter"

pathawks commented 6 years ago

Maybe “username on social network” ?

DirtyF commented 6 years ago

Correct me if I'm wrong but title attribute isn't necessarily read by screenreaders: https://www.deque.com/blog/text-links-practices-screen-readers/

jekyllbot commented 6 years ago

This issue has been automatically marked as stale because it has not been commented on for at least two months.

The resources of the Jekyll team are limited, and so we are asking for your help.

If this is a bug and you can still reproduce this error on the master branch, please reply with all of the information you have about it in order to keep the issue open.

If this is a feature request, please consider whether it can be accomplished in another way. If it cannot, please elaborate on why it is core to this project and why you feel more than 80% of users would find this beneficial.

This issue will automatically be closed in two months if no further activity occurs. Thank you for all your contributions.

DirtyF commented 6 years ago

@austinseraphin aria-label was added in #302

mgifford commented 4 years ago

What is the status of this?

austinseraphin commented 3 years ago

As of version 2.5.1 the links still read as the user ID. They should say the name of the social network instead, i.e. Twitter.

mgifford commented 3 years ago

As @DirtyF suggested. Titles aren't good for this. This info should be in the alt attribute instead of title.

austinseraphin commented 3 years ago

Yes. All meaningful images should have alt tags, and all placeholder images shouldn't Usually Minima does a good job with this. If the social media icons have the wrong alt text then that would cause the screen reader to misread them.