search

jekyll / minima

Minima is a one-size-fits-all Jekyll theme for writers.
https://jekyll.github.io/minima/
MIT License
3.39k stars 3.6k forks source link

Sass files not available by default #752

Closed DevOpsJeremy closed 1 week ago

DevOpsJeremy commented 1 year ago

The section Customizing templates instructs to simply create an assets/css/style.scss file and, optionally, _sass/minima/custom-styles.scss & custom-variables.scss. However, the build fails without the remaining Sass files since they are referenced in style.scss.

Example 1

After adding assets/css/style.scss and populating it with the following in accordance with Customizing templates:

---
---

@import
  "minima/skins/{{ site.minima.skin | default: 'classic' }}",
  "minima/initialize";

The build failed with the following error:

Conversion error: Jekyll::Converters::Scss encountered an error while converting 'assets/css/style.scss': File to import not found or unreadable: minima/skins/classic. Load paths: /usr/local/bundle/gems/minima-2.5.1/_sass /usr/local/bundle/gems/minima-2.5.1/_sass on line 2

Log file: Example 1.txt

Example 2

After adding the skins to _sass/minima/skins, the build still failed with the following error:

Conversion error: Jekyll::Converters::Scss encountered an error while converting 'assets/css/style.scss': File to import not found or unreadable: minima/initialize. Load paths: /github/workspace/_sass /usr/local/bundle/gems/minima-2.5.1/_sass /usr/local/bundle/gems/minima-2.5.1/_sass on line 3

Log file: Example 2.txt

Of course, manually adding the Sass source files resolves this issue, but this overrides the "defaults" and the files should be available without having to manually include them, so that the site stays "in sync with upstream changes released in future versions".

mvallebr commented 1 year ago

I am new to minima and I am having this problem as well - any short term workaround?

ashmaroli commented 1 year ago

The README instructions you're referring to is for the unreleased Minima 3.0. To view instructions for v2.5.x, change the repository branch / tree accordingly.

jekyllbot commented 10 months ago

This issue has been automatically marked as stale because it has not been commented on for at least two months.

The resources of the Jekyll team are limited, and so we are asking for your help.

If this is a bug and you can still reproduce this error on the master/main branch, please reply with all of the information you have about it in order to keep the issue open.

If this is a feature request, please consider whether it can be accomplished in another way. If it cannot, please elaborate on why it is core to this project and why you feel more than 80% of users would find this beneficial.

This issue will automatically be closed in two months if no further activity occurs. Thank you for all your contributions.