search

jekyll / minima

Minima is a one-size-fits-all Jekyll theme for writers.
https://jekyll.github.io/minima/
MIT License
3.44k stars 3.64k forks source link

Changing the default layout from `default` to `base` was a questionable idea #771

Closed michaelnordmeyer closed 2 months ago

michaelnordmeyer commented 10 months ago

In https://github.com/jekyll/minima/pull/690 the default layout was renamed from default.html to base.html.

While the given rationale is not wrong, it ignores the Jekyll documentation regarding layouts:

The convention is to have a base template called default.html and have other layouts inherit from this as needed.

There is a plugin called jekyll-default-layout, which is installed through the GitHub Pages gem by default.

A solution for having both was mentioned in https://github.com/jekyll/minima/pull/690#issuecomment-1435078904, but I don't think there's much to gain by having a layout called base instead of default. It most likely leads to more confusion.

I for one consider the default naming scheme to be more helpful, because it conveys the notion that this is the default layout, which will be used as default if nothing is declared, and is not extended with any particular functionality, which might only apply to a subset of pages.

What do you think?

ashmaroli commented 2 months ago

because it conveys the notion that this is the default layout, which will be used as default if nothing is declared

This is the exact reason why I chose to rename default.html to base.html. The jekyll-default-layout is a GitHub Pages-specific extension and not a core Jekyll feature or functionality.