jekyllt / jasper

Full-featured Jekyll port of Ghost's default theme Casper 👻
https://jekyller.github.io/jasper/
MIT License
581 stars 348 forks source link

Missing characters in typographic ligatures "fi" -> "i" #18

Closed gully closed 8 years ago

gully commented 8 years ago

Hi there, The Jekyll theme has been working great, thanks again for putting it together.

One strange thing I noticed today-- all of the instances of the two-letter sequence "fi" were replaced with "i", in the content of my blog posts. It's definitely something about the font because the developer tools shows the original "fi" content. It's a problem with the ligature for blended fi typography. I'm not quite sure how to go about fixing it, other than trying to change the font. Has anyone else experienced this? It's conceivable I screwed something up while mucking around with the multiple author support experiments, so forgive me if this is my own problem. I've replicated the behavior on several different browsers and devices, and I see it serving both locally and remote. I'll report back about what I find out.

gully commented 8 years ago
screen shot 2016-01-24 at 2 01 17 pm
JohnONolan commented 8 years ago

https://github.com/google/fonts/issues/8

davelab6 commented 8 years ago

The update to Merriweather was made in advance of the Firefox 44 launch on Tuesday that will mean the old files will just stop working.

The bug with fi/fl ligatures has a workaround - you can turn ligatures off with CSS to work around this until then:

-webkit-font-feature-settings: 'liga' 0, 'onum' 1, 'kern' 1;
-moz-font-feature-settings: 'liga' 0, 'onum' 1, 'kern' 1;
-o-font-feature-settings: 'liga' 0, 'onum' 1, 'kern' 1;
font-feature-settings: 'liga' 0, 'onum' 1, 'kern' 1;
gully commented 8 years ago

Thank you all, it looks like this affected a lot of pages out there.

biomadeira commented 8 years ago

Great help guys @JohnONolan @davelab6 and @gully!

I had no idea about this one...

Cheers

rphuber commented 8 years ago

You could also get the font from fontsquirrel for free and host it yourself. It is more up to date than the one hosted on google. That worked to fix the issue for me.

davelab6 commented 8 years ago

@rphuber if you do that, the italics will stop working tomorrow for Firefox 44 users (which you can test today with Firefox Developer Edition)

davelab6 commented 8 years ago

The fix was pushed to the Google Fonts API, so you should be able to confirm and close this now

biomadeira commented 8 years ago

Thank you all guys! The problem has been resolved so all good ;)