jekyllt / jasper2

Full-featured Jekyll port of Ghost's default theme Casper v2 👻
https://jekyllt.github.io/jasper2/
MIT License
762 stars 658 forks source link

add algolia search #81

Open diomed opened 5 years ago

diomed commented 5 years ago

there is this algolia example:

https://github.com/algolia/jekyll-algolia-example

from which one can extrapolate search, and integrate into jasper2

diomed commented 5 years ago

@LorenzoLeonardini could you maybe give a shot to this?

LorenzoLeonardini commented 5 years ago

This repo wants to be a "perfect" copy of the original Casper2 theme, which has no search bar.

Therefore I wouldn't suggest adding an issue here, but forking the repo to work on that "privately".

Personally I wouldn't know where to put the search box without spoiling the theme (but I'm not really into UI and UX, so maybe someone could have a good idea)

diomed commented 5 years ago

I already know where. It would replace subscribe, and would be placed in fullscreen modal

rnehra01 commented 5 years ago

@LorenzoLeonardini How does this look?

diomed commented 5 years ago

@rnehra01 this project code is not open to public??

rnehra01 commented 5 years ago

Actually, I am making some changes to the theme and adding some stuff, so I am thinking of making it public when I'm done.

diomed commented 5 years ago

@rnehra01 hello. what about this in the end?

rnehra01 commented 5 years ago

@diomed ??

diomed commented 5 years ago

@rnehra01 is it gonna be public soon?

rnehra01 commented 5 years ago

Yup, I'll let you know.

rnehra01 commented 5 years ago

@diomed https://github.com/rnehra01/rnehra01.github.io

MaxGhenis commented 3 years ago

@rnehra01 Are these the relevant commits to integrate?

rnehra01 commented 3 years ago

@MaxGhenis Yes I think these are all you need.