jelgblad / angular2-masonry

https://github.com/desandro/masonry module for Angular2
101 stars 48 forks source link

Not found masonry-layout #1

Closed Olexiy665 closed 8 years ago

Olexiy665 commented 8 years ago

Thank you for you angular2-masonry component. But I have a problem. I did everything according instrution, but got error:

GET http://localhost:3000/masonry-layout 404 (Not Found)   zone.js:101
Error: Error: XHR error (404 Not Found) loading http://localhost:3000/masonry-layout(…) (index):25
jelgblad commented 8 years ago

Thank you for noticing! I've changed how the masonry-layout library is loaded. You need to add "masonry-layout": "node_modules/masonry-layout/dist/masonry.pkgd.js" to paths in your SystemJS config. The <script src="node_modules/masonry-layout/dist/masonry.pkgd.min.js"></script> can be removed from index.html. I've updated README.md.

Olexiy665 commented 8 years ago

I have a problem again. I have installed angular2-masonry from npm, zone.js:101 GET http://localhost:3000/node_modules/angular2-masonry/index.js 404 (Not Found), but if I downloaded from github, I get node_modules/angular2-masonry/src/masonry.ts(3,26): error TS2307: Cannot find module 'masonry-layout'.

jelgblad commented 8 years ago

My bad. I've changed the system.js-main script from angular2-masonry.js to index.js to stay in-line with the angular2 community. I've made these changes on github but I've not published to npm yet. You can change main back to angular2-masonry.js as it will still be supported. I'm publishing 0.0.19 with these changes tonight.

Olexiy665 commented 8 years ago

Thank you!