search

jelgblad / angular2-masonry

https://github.com/desandro/masonry module for Angular2
101 stars 48 forks source link

Fix Typescript strict type checking errors #20

Closed bradyisom closed 8 years ago

bradyisom commented 8 years ago

First off, thank you for your work in providing this simple, but very useful library.

In our project we are using strict type checking in our Typescript. We are also using this project. We are using angular-cli/webpack to compile our project. With that kind of a setup, there is currently no way to ignore typescript errors/warning from third-party libraries.

This PR resolves issues in this library that allows us to turn on strictNullChecks and noImplicitAny options in our tsconfig.json without getting warnings from this library.

jelgblad commented 8 years ago

Perfect! Thanks.

jelgblad commented 8 years ago

Comments on this? #22

bradyisom commented 8 years ago

Yes, there are various issues, including in the main Angular library as all of these errors and warnings get flushed out. I did see those errors while compiling the angular2-masonry library with the strictNullChecks turned on. However, turning it off has the same problem that turning it off in my own project has. To hide the third party errors/warnings you also have to hide errors/warnings in your own project. Therefore, there is a chance that you can check in something that adds errors/warnings to the build of a project downstream that has strictNullChecks turned on. Either way this project is stuck in the middle. You either live with the third party Angular errors while building this project, or you take the chance that you can cause some of those same errors in downstream projects. It's up to you @jelgblad, as the maintainer of the project, which one you want to live with.

jelgblad commented 8 years ago

I think I'm with you on this one. For all the reasons above and that strictNullChecks turned off seems more of a hack. I'll stick with keeping it turned on. Thanks!