jelhan / create-github-actions-setup-for-ember-addon

Setup GitHub Actions for an Ember Addon
MIT License
19 stars 2 forks source link

All Ember Try Scenarios should run if one fails #45

Closed jelhan closed 3 years ago

jelhan commented 3 years ago

This pull requests enables continue-on-error for all Ember Try Scenarios. So far it was only set to true for scenarios, which were allowed to fail in Travis CI configuration.

Travis CI's allow-failure option and GitHub Action's continue-on-error option are not comparable:

The difference between both and the need for an option like Travis CI's allow-failure in GitHub Actions is discussed in this thread: https://github.com/actions/runner/issues/2347

It makes sense to run all Ember Try Scenarios always regardless if one fails:

Fixes actions/toolkit#43