search

jelhan / ember-style-modifier

{{style}} element modifier for ember.js
MIT License
36 stars 12 forks source link

Element type incorrect in modifier signature #225

Open bwbuchanan opened 8 months ago

bwbuchanan commented 8 months ago

https://github.com/jelhan/ember-style-modifier/blob/c2869d500e965599cb92a81ab6cf596cf62131dd/addon/modifiers/style.ts#L47

This should be:

Element: ElementCSSInlineStyle;

Otherwise, the Typescript compiler complains when you try to use the modifier on SVG elements.

jelhan commented 8 months ago

Thanks for reporting. Do you have time providing a PR, which 1) fixes the issue and 2) adds test coverage for SVG usage?

jelhan commented 7 months ago

It has been fixed for SVG elements in #235. While working on the fix, we noticed that it is broken for <math> element as well. A fix for that one is pending. See #237 for details.