search

jellekralt / Responsive-Tabs

Responsive Tabs is a jQuery plugin that provides responsive tab functionality. The tabs transform to an accordion when it reaches a CSS breakpoint. You can use this plugin as a solution for displaying tabs elegantly on desktop, tablet and mobile.
http://jellekralt.github.io/Responsive-Tabs/
MIT License
531 stars 228 forks source link

Responsive animation settings #136

Closed coxrichuk closed 6 years ago

coxrichuk commented 7 years ago

I am using vanilla window.matchMedia to change the animation settings by breakpoint taking advantage of $tabs.responsiveTabs('option', 'animation', 'fade');

This works really well by the way !!

However if I have 3 breakpoints and I switch between fade, slide and default when default is set it is changing my original duration to 0

Can I suggest rather than overwriting this globally ie _this.options.duration = 0 this is just overwritten at the function level ie disabled: 0?

I can submit a PR if it would help?

What I have in mind would be a non breaking change

jellekralt commented 6 years ago

Feel free to submit a PR

jellekralt commented 6 years ago

I'm closing the issue since there has been no activity for a while. Feel free to reopen if you feel this is still unresolved.