search

jelleroorda / social-divi

Allow you to easily add more social icons to Divi
Other
3 stars 3 forks source link

Twitter to X: Please replace icon with "X", change text to "Twitter (X)", etc. #3

Open lsthompson opened 5 months ago

lsthompson commented 5 months ago

Can keep internal ref/name the same. Mostly the icon.

jelleroorda commented 5 months ago

Hi Luke,

I've noticed that the X brand icon is not available for font awesome 5 (which is what I'm currently using to test).

What version are you currently using? Not sure what would be the best way to go about this; it would probably require a v2 of the plugin. Currently it's using FA5 with fab fa-icon-name, but that would all need to be converted to fa-brands fa-icon-name.

I think putting out a v2 with FA6 would additionally require people to set up a FA account + their kits. As far as I have seen there is a limited "free plan".

Any thoughts?

Zodiac1978 commented 5 months ago

Why don't using the "ETmodules" font instead? This would solve the dependency for the Font Awesome plugin and you have the X icon already. Just following the "Social Icons" module.

jelleroorda commented 5 months ago

Hi Torsten, thanks for the suggestion.

Having a quick look at the available icons it doesn't seem that all icons are available that the plugin currently supports (for example: telegram, tiktok, twitch to name a few).

However, dropping Fontawesome as a dependency and going for another (open source) icon library might be a good idea going forward.

Zodiac1978 commented 5 months ago

The page is not up-to-date. I just checked the Social Media module in the recent Divi and all three are supported.

This is the complete list: Amazon Bandcamp Behance BitBucket Buffer dribbble Facebook Flickr FlipBoard Foursquare GitHub Goodreads Google Houzz Instagram Itunes Last.fm Linie LinkedIn Medium Meetup MySpace Odnoklassniki Patreon Periscope Pinterest Quora Reddit ResearchGate RSS skype Snapchat SoundCloud Spotify Steam Telegram TikTok TripAdvisor tumblr Twitch X Vimeo VK Weibo Whatsapp XING Yelp Youtube

But compared to your list, there are indeed some missing: Apple, Xing, Discord

lsthompson commented 3 months ago

Elegant Themes have updated it in the core footer icon set.

So this makes me wonder if you could inherit that one instead of sourcing from FA?

techsurrusr commented 1 month ago

On the above list https://rumble.com/ is missing.