jelleschutter / remarkable-firefox

Unoffical reMarkable AddOn for Firefox.
https://addons.mozilla.org/en-GB/firefox/addon/unofficial-remarkable/
67 stars 5 forks source link

fix AMO auth timestamp and key issues #4

Closed akdor1154 closed 2 years ago

akdor1154 commented 2 years ago

This should probably fix #3 (it was needed when running here), and make future problems a little clearer. N.B. I'm not sure if the key changes are breaking for you - I'm running by copy-pasting my AMO key straight into an env file that looks like

MOZILLA_API_KEY=user:12132989:***
MOZILLA_API_SECRET=abc...

and running with

env $(cat environment) python ./publish_firefox.py

.

If you've pre-encoded your API secret in Github or something then this would be a breaking change for you (but it would mean you can copy future keys straight in from the AMO page without doing anything to the first). I can't really tell sorry because I can't see your CI secrets :)

jelleschutter commented 2 years ago

This PR was superseded by #6 which is based on the source fork/branch of this PR.