jelly-beam / rebar3_ex_doc

rebar3 plugin for generating docs with ex_doc
Apache License 2.0
43 stars 13 forks source link

[automation] Update `ex_doc` to 0.31.2 #84

Closed github-actions[bot] closed 8 months ago

github-actions[bot] commented 8 months ago

This is an automated action to update ex_doc to version 0.31.2

paulo-ferraz-oliveira commented 8 months ago

@starbelly, could you try (on top of this pr), for the checkout action (in up_ex_doc_version.yml), to do

      - uses: actions/checkout@v4
        with:
          token: ${{${{ secrets.GITHUB_TOKEN }}}}

My expectation is that the checks run after that, since there's some sort of authentication from GitHub.

starbelly commented 8 months ago

@starbelly, could you try (on top of this pr), for the checkout action (in up_ex_doc_version.yml), to do

      - uses: actions/checkout@v4
        with:
          token: ${{${{ secrets.GITHUB_TOKEN }}}}

My expectation is that the checks run after that, since there's some sort of authentication from GitHub.

Sorry, not following.

paulo-ferraz-oliveira commented 8 months ago

There's an error in my input example, but

      - uses: actions/checkout@v4
        with:
          token: ${{secrets.GITHUB_TOKEN}}

at https://github.com/starbelly/rebar3_ex_doc/blob/main/.github/workflows/up_ex_doc_version.yml#L25 should make CI run for this type of pull request (ref: https://docs.github.com/en/actions/security-guides/automatic-token-authentication). I'll test my hypothesis in my fork of this.

Edit: if it works I'll try to summarise my understanding of this, which I didn't previously.

paulo-ferraz-oliveira commented 8 months ago

Hm...

When you use the repository's GITHUB_TOKEN to perform tasks, events triggered by the GITHUB_TOKEN, with the exception of workflow_dispatch and repository_dispatch, will not create a new workflow run.

😢 I think I'd read this before, and tried stuff to go around it. It still makes little sense this is not available as a feature.

Edit: I'll propose a different solution to this issue. Feel free to merge and close, if you see fit.

starbelly commented 8 months ago

I'll go ahead and merge it since I want us to be up to date, such that I can cut a release today.