jellybob / activo-rails

Activo is a theme for Web-app-theme, Formtastic and Attrtastic. This is a Rails plugin to make it painfully easy to use.
http://dmfrancisco.github.com/activo/
MIT License
42 stars 8 forks source link

use 'provide :title, "foo"' instead of the custom page_title helper #10

Closed tobsch closed 13 years ago

tobsch commented 13 years ago

Would be the Rails way, IMHO.

What do you think?

jellybob commented 13 years ago

I had no idea that existed to be honest - is there some documentation for it somewhere, because I can't find any?

Assuming it's part of the public Rails API, then I'm very happy not to have custom helpers for something that simple, but I don't want it to break in a future release where they decide that method isn't in fact needed.

Jon Wood Blank Pad Development

On Monday, 13 June 2011 at 11:32, tobsch wrote:

Would be the Rails way, IMHO.

What do you think?

Reply to this email directly or view it on GitHub: https://github.com/jellybob/activo-rails/issues/10

tobsch commented 13 years ago

ah, hehe, it is rails 3.1 aswell: http://www.rubyonrails.de/2011/05/screencast-http-streaming/

we'll do it in the 3.1 branch :)

jellybob commented 13 years ago

Done. This will fall back to the page_title method if no content was provided.