fixed "controls" helper icons

jellybob / activo-rails

Activo is a theme for Web-app-theme, Formtastic and Attrtastic. This is a Rails plugin to make it painfully easy to use.

http://dmfrancisco.github.com/activo/

MIT License

42 stars 8 forks source link

fixed "controls" helper icons #27

Closed Jonplussed closed 12 years ago

Jonplussed commented 12 years ago

The "controls" helper was incorrectly displaying the icons from the 16x16 icon directory, rather than the seemingly-intended parent directory. This sets the correct path and also adds a space between the icon and the label so that the buttons don't look so smushed.

Jonplussed commented 12 years ago

If this is accepted, the same error is present on the rails3_1 branch.

jellybob commented 12 years ago

I like the change in formatting, but if the icon helper isn't defaulting to the small size that's what needs fixing, rather then changing the controls helper to use image_tag - would you mind having a look at that?

If not I'm quite happy to, but since I'm away for Christmas at the moment I won't be able to until the new year.

Jonplussed commented 12 years ago

Whoops, error on my part:

On the rails3_1 branch, the Fatcow icons exist in app/assets/images/icons, rather than in /16x16. I'm assuming that these are the icons meant to be used in the control buttons, rather than the 16x16 Silk icons, since Fatcow icons are used in all Activo previews.
On the master branch, the 16x16 are the Silk icons (though 'edit' is missing), but I'm guessing Fatcow icons are supposed to be used like in the Activo previews.

Anyways, sorry for the confusion. Let me know what changes you'd like and I'll submit a separate pull request for each branch.