search

jellybob / activo-rails

Activo is a theme for Web-app-theme, Formtastic and Attrtastic. This is a Rails plugin to make it painfully easy to use.
http://dmfrancisco.github.com/activo/
MIT License
42 stars 8 forks source link

Breadcrumb escape issue fixed. #3

Closed NeMO84 closed 13 years ago

NeMO84 commented 13 years ago

Breadcrumb , similar to navigation, should also be marked html_safe or data is escaped.

jellybob commented 13 years ago

Thanks, I'll merge this later on today.

jellybob commented 13 years ago

Hi, I've pushed the addition of html_safe to master now, but could you add some tests for the other two commits please?

If you're not sure how to, I'm quite happy to help, but I don't want functional changes going in without an accompanying test to make sure I don't break it later.

NeMO84 commented 13 years ago

Hey,

I can definitely do this. In fact I already wrote up the tests on my local box but I am not sure what I need to do to run the tests. Could you advise?

Thanks!

jellybob commented 13 years ago

Excellent :)

The tests are implemented using RSpec, and can be run using rake spec which will run anything found in spec/*_spec.rb

jellybob commented 13 years ago

Ahh, just noticed this now, thanks :)

I'll merge it in at some point today.

jellybob commented 13 years ago

Sorry, I've been utterly useless with this. I've just pushed the other changes and released a new version.