Fix module import error by using typing.List

jellydn / CopilotChat.nvim

Chat with GitHub Copilot in Neovim

GNU General Public License v3.0

100 stars 9 forks source link

Fix module import error by using typing.List #33

Closed Cassius0924 closed 8 months ago

Cassius0924 commented 8 months ago

WHAT

gptlang/CopilotChat.nvim#18 neovim/pynvim#560

WHY

Using list in Python 3.8 results in an error : TypeError: 'type' object is not subscriptable

HOW

Screenshots (if appropriate):

Types of changes

[x] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

[x] Linter
[x] Tests
[x] Review comments
[x] Security

changeset-bot[bot] commented 8 months ago

⚠️ No Changeset found

Latest commit: 24789eed45d61aee231e157be9175cda3e9b0a51

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

jellydn commented 8 months ago

Thanks @Cassius0924 LGTM!

jellydn commented 8 months ago

@all-contributors add @Cassius0924 for code

allcontributors[bot] commented 8 months ago

@jellydn

I've put up a pull request to add @Cassius0924! :tada: