Closed hsanson closed 6 months ago
Latest commit: ab9977987831fbfe06868711aad30a71a26329c1
Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.
Click here to learn what changesets are, and how to add one.
Click here if you're a maintainer who wants to add a changeset to this PR
This is an automated message generated by Sweep AI.
Thanks. I will take a try tonight.
FYI - Just synced your change to https://github.com/jellydn/hurl.nvim/tree/canary and the PR is not working properly yet.
FYI - Just synced your change to https://github.com/jellydn/hurl.nvim/tree/canary and the PR is not working properly yet.
Please let me know what issues you are experiencing and if possible a sample hurl file to reproduce them. I have tested it on my hurl files and seems to work properly.
FYI - Just synced your change to
canary
and the PR is not working properly yet.Please let me know what issues you are experiencing and if possible a sample hurl file to reproduce them. I have tested it on my hurl files and seems to work properly.
Sure, I will push my test file to repository so you could try as well.
Hi @hsanson Here is the simple test file https://github.com/jellydn/hurl.nvim/commit/ae57eba85eafd80d54c1f10c2d212383e8e55389 It works with main
but not working properly with canary
branch.
Just FYI - I've reverted to using the find verb instead of treesitter parser.
Reproduce:
HurlRunnerAt
The canary
branch will return the Google response
instead of manga API
. @hsanson
Canary:
Main:
@jellydn sorry for the issue... please test if this fixes it for you:
Thanks @hsanson Almost there. The parser logic will failed if there is a comment on hurl, e.g: https://github.com/jellydn/hurl.nvim/commit/9f773eff4a061d7d5e66a1c58af345dc365b6417
For now, this is my solution :) https://github.com/jellydn/hurl.nvim/commit/4d4e4ff9df020522dca8a6dc9ea7fd3dfa25069d
@jellydn simple solution and seems to work as far as I can see... thanks. Better than trying to fix the treesitter parser that does not seem to properly parse the comments and treat them as errors. Specially the top most comment.
You can see how the treesitter sees the file using :InspectTree
. This is a very useful tool to understand hurl grammar.
Great. Thanks, @hsanson Also, the treesitter parser
only works for nightly. I will bring the find verb back to fallback on stable version.
WHAT
Modify HurlRunnerToEntry to work using treesitter parser. This allows to run to a specific entry without having to be exactly located at the start of the entry where the verb is located.
WHY
HOW
Screenshots (if appropriate):
Types of changes
Checklist: