Closed agriffis closed 3 months ago
Open the branch in Web Editor • VS Code • Insiders
Open Preview
Latest commit: 2cb2e795375de0e21902c7b945f0a1c4b59f6fff
Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.
Click here to learn what changesets are, and how to add one.
Click here if you're a maintainer who wants to add a changeset to this PR
The recent changes streamline the configuration handling of the spinner logic by removing the show_notification
field from the local config
table and instead relying on the global configuration _HURL_GLOBAL_CONFIG.show_notification
. This simplifies condition checks within the M.hide
function, ensuring that the notification setting is consistently sourced from the global configuration.
File | Change Summary |
---|---|
lua/hurl/spinner.lua |
Removed the show_notification field from the config table and updated the M.hide function to use _HURL_GLOBAL_CONFIG.show_notification instead. |
In the code where spinners spin,
Configurations now run thin.
Global settings take the stage,
Gone is the redundant page.
Simplified, refined, oh what a win!
Our spinner hides with a global grin.
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?
Thanks @agriffis LGTM!
@all-contributors add @agriffis for code.
@jellydn
I've put up a pull request to add @agriffis! :tada:
WHAT
spinner didn't honor
show_notification
WHY
to avoid "Done!" message
Types of changes
Checklist:
Summary by CodeRabbit
show_notification
configuration.