Viroide commented 6 months ago

Details

❗ After some debugging, I found that the body is truncated, probably the payload is too big. ❗

I have both installed jq and prettier any clue?

debug info

[INFO  Wed Mar  6 13:52:12 2024] ...utils.lua:19: hurl: request finished
[INFO  Wed Mar  6 13:52:12 2024] ...utils.lua:19: Detected content type: application/json; charset=utf-8
[INFO  Wed Mar  6 13:52:12 2024] ...utils.lua:19: formatting body with json
[ERROR Wed Mar  6 13:52:12 2024] ...utils.lua:30: formatter failed4

Checklist

- [X] Modify `lua/hurl/utils.lua` ✓ https://github.com/jellydn/hurl.nvim/commit/0c558503f490a73b0d7c9cec5b8396ca7e92e9d8 [Edit](https://github.com/jellydn/hurl.nvim/edit/sweep/the_response_is_not_formatted_jsonhtml/lua/hurl/utils.lua#L105-L128) - [X] Running GitHub Actions for `lua/hurl/utils.lua` ✗ [Edit](https://github.com/jellydn/hurl.nvim/edit/sweep/the_response_is_not_formatted_jsonhtml/lua/hurl/utils.lua#L105-L128) - [X] Modify `lua/hurl/main.lua` ! No changes made [Edit](https://github.com/jellydn/hurl.nvim/edit/sweep/the_response_is_not_formatted_jsonhtml/lua/hurl/main.lua#L216-L246) - [X] Running GitHub Actions for `lua/hurl/main.lua` ✗ [Edit](https://github.com/jellydn/hurl.nvim/edit/sweep/the_response_is_not_formatted_jsonhtml/lua/hurl/main.lua#L216-L246)

sweep-ai[bot] commented 6 months ago

🚀 Here's the PR! #102

See Sweep's progress at the progress dashboard!

⚡ Sweep Basic Tier: I'm using GPT-4. You have 2 GPT-4 tickets left for the month and 3 for the day. (tracking ID: bd1a75fe6f)

For more GPT-4 tickets, visit our payment portal. For a one week free trial, try Sweep Pro (unlimited GPT-4 tickets).

[!TIP] I can email you next time I complete a pull request if you set up your email here!

Actions (click)

[ ] ↻ Restart Sweep

GitHub Actions✓

Here are the GitHub Actions logs prior to making any changes:

Sandbox logs for b829cda

Checking lua/hurl/utils.lua for syntax errors... ✅ lua/hurl/utils.lua has no syntax errors! 1/1 ✓
Checking lua/hurl/utils.lua for syntax errors...
✅ lua/hurl/utils.lua has no syntax errors!

Sandbox passed on the latest main, so sandbox checks will be enabled for this issue.

Step 1: 🔎 Searching

I found the following snippets in your repository. I will now analyze these snippets and come up with a plan.

Some code snippets I think are relevant in decreasing order of relevance (click to expand). If some file is missing from here, you can mention the path in the ticket description.

https://github.com/jellydn/hurl.nvim/blob/b829cda49772f40801c957f5076b8b023cf48073/lua/hurl/utils.lua#L100-L128 https://github.com/jellydn/hurl.nvim/blob/b829cda49772f40801c957f5076b8b023cf48073/lua/hurl/main.lua#L216-L246

I also found the following external resources that might be helpful:

**Summaries of links found in the content:**

Step 2: ⌨️ Coding

[X] Modify lua/hurl/utils.lua ✓ https://github.com/jellydn/hurl.nvim/commit/0c558503f490a73b0d7c9cec5b8396ca7e92e9d8 Edit
Modify lua/hurl/utils.lua with contents:
• In the `util.format` function, change how the body is passed to the external formatter. Instead of passing the body directly as a command-line argument, write the body to a temporary file and pass the file path to the formatter. This approach can handle larger payloads.
• Replace line 115 with code to write `body` to a temporary file. Use `vim.fn.tempname()` to generate a temporary file name, and `vim.fn.writefile(vim.split(body, '\n'), tempFilePath)` to write the body to the file.
• Modify the command in `formatters[type]` to include the temporary file path instead of passing `body` directly. For example, if `type` is `json`, the command should be modified to include the temporary file path as an argument to `jq`.
• After running the formatter, read the formatted body from the temporary file using `vim.fn.readfile(tempFilePath)` and store it in `stdout`.
• Add error handling for file operations (writing to and reading from the temporary file). Use `pcall` to catch any errors during these operations and log them using `util.log_error`.
• Ensure to delete the temporary file after reading the formatted content or in case of any errors during file operations.
• Update the logging and notification messages to include more descriptive error information if the formatter fails or file operations encounter errors.

--- 
+++ 
@@ -112,13 +112,23 @@
   end

   util.log_info('formatting body with ' .. type)
-  local stdout = vim.fn.systemlist(formatters[type], body)
-  if vim.v.shell_error ~= 0 then
-    util.log_error('formatter failed' .. vim.v.shell_error)
-    util.notify('formatter failed' .. vim.v.shell_error, vim.log.levels.ERROR)
+  local tempFilePath = vim.fn.tempname()
+  local ok, err = pcall(vim.fn.writefile, vim.split(body, '\n'), tempFilePath)
+  if not ok then
+    util.log_error('Failed to write to temp file: ' .. err)
+    util.notify('Failed to write to temp file: ' .. err, vim.log.levels.ERROR)
     return vim.split(body, '\n')
   end
-
+  -- Modify the command to use the temp file path
+  local modifiedCommand = vim.tbl_deep_extend("force", formatters[type], {tempFilePath})
+  local stdout, readErr = pcall(vim.fn.readfile, tempFilePath)
+  if not stdout or #stdout == 0 then
+    util.log_error('Failed to read formatted body from temp file: ' .. (readErr or 'Unknown error'))
+    util.notify('Failed to read formatted body from temp file: ' .. (readErr or 'Unknown error'), vim.log.levels.ERROR)
+    return vim.split(body, '\n')
+  end
+  -- Ensure to delete the temporary file
+  os.remove(tempFilePath)
   if stdout == nil or #stdout == 0 then
     util.log_info('formatter returned empty body')
     return vim.split(body, '\n')

[X] Running GitHub Actions for lua/hurl/utils.lua ✗ Edit
Check lua/hurl/utils.lua with contents:

Ran GitHub Actions for 0c558503f490a73b0d7c9cec5b8396ca7e92e9d8:
• pandoc to vimdoc: ⋯
• lint: ✗
• Run Test: ✓

[X] Modify lua/hurl/main.lua ! No changes made Edit
Modify lua/hurl/main.lua with contents:
• No direct modifications are required in this file to address the issue. However, ensure that the changes made in `lua/hurl/utils.lua` do not affect how the `container.show` function is called with the formatted body. The modifications in `lua/hurl/utils.lua` should be transparent to the callers of `util.format`.
• Review the handling of the formatted body in the `container.show` function calls to ensure that large payloads are displayed correctly in the UI. If necessary, adjust the logic to handle large strings efficiently, possibly by implementing pagination or truncation with an option to view more.

[X] Running GitHub Actions for lua/hurl/main.lua ✗ Edit
Check lua/hurl/main.lua with contents:

Step 3: 🔁 Code Review

I have finished reviewing the code for completeness. I did not find errors for sweep/the_response_is_not_formatted_jsonhtml.

🎉 Latest improvements to Sweep:

New dashboard launched for real-time tracking of Sweep issues, covering all stages from search to coding.
Integration of OpenAI's latest Assistant API for more efficient and reliable code planning and editing, improving speed by 3x.
Use the GitHub issues extension for creating Sweep issues directly from your editor.

💡 To recreate the pull request edit the issue title or description. To tweak the pull request, leave a comment on the pull request.^{Something wrong? Let us know.}

This is an automated message generated by Sweep AI.

skoch13 commented 6 months ago

I have the very same issue, moreover ever the 'headers table' is getting truncated too.

jellydn commented 6 months ago

Thank you @Viroide for your report. It's failed on the format process: formatter failed4. I will try to reproduce the issue sometime this week. PR's welcome if you could reproduce the issue on your own.

jellydn / hurl.nvim

The response is not formatted (json/html) #98