WIP: Jellyfin port - Githubissues

hawken93 commented 5 years ago

Totally broken at the moment.

hawken93 commented 5 years ago

I think logging is fine, but I'm going to remove unused logging things..

hawken93 commented 5 years ago

Random errors all over the place.

MediaSourceInfo doesn't seem like a good replacement for ChannelMediaInfo. I'll try to figure out what would be better and redo that
ImageMagickSharp problems, this has to be ported over (SoundCloud thingy uses it)
Some weird System things because we are compiling against netstandard2.0

hawken93 commented 5 years ago

Summary of leftover errors and warnings:

ChannelItemInfo does not contain IsInfiniteStream
MediaSourceInfo does not contain *
async method lacks await operators, will run synchronously
SoundCloud has a Magick implementation that I'm trying to port
Trailer: IIndexableChannel, InternalAllChannelMediaQuery not found
some exceptions in Vimeo that went unused, but the two classes probably need loggers first

hawken93 commented 5 years ago

Also, this PR is insanely big after removing random crap so I'll just go ahead and do whitespace fixing in here too. Will keep the commits separated..

joshuaboniface commented 5 years ago

@hawken93 How's this one looking from your side - still WIP?

hawken93 commented 5 years ago

@joshuaboniface This one is a lot of work but this PR already gets it far. Could need help from @cvium or @Bond_009 to iron out the remaining errors

hawken93 commented 5 years ago

I'd like to have that as advice though, since I'm planning to rewrite all my commits and reorder them as logically as possible to keep everything clean and understandable

hawken93 commented 5 years ago

I think some channels can just be nuked entirely. Moving that to the beginning of the commit order removes any changes I've done to that code so that the other commits won't contain crap

hawken93 commented 5 years ago

This code is a year old so in my understanding this is a matter of up-porting the code. Something the other devs know more about than me since they know the code base more intimately

hawken93 commented 5 years ago

I've removed Revision3 and put it first in the history. Also split a commit to make it understandable

hawken93 commented 5 years ago

@cvium I've finally gotten around to address your review. There are things I left in there where I would like input / help..

hawken93 commented 5 years ago

Here are the errors I could use help with:

ChannelMediaInfo:

Channel.cs(143,39): error CS0246: The type or namespace name 'ChannelMediaInfo' could not be found (are you missing a using directive or an assembly reference?) [/home/hawken/git/plugins-1-todo/jellyfin-plugin-channels/MediaBrowser.Channels.iPlayer/MediaBrowser.Channels.iPlayer.csproj]
RSS.cs(30,28): error CS0246: The type or namespace name 'ChannelMediaInfo' could not be found (are you missing a using directive or an assembly reference?) [/home/hawken/git/plugins-1-todo/jellyfin-plugin-channels/MediaBrowser.Channels.iPlayer/MediaBrowser.Channels.iPlayer.csproj]
RSS.cs(74,40): error CS0246: The type or namespace name 'ChannelMediaInfo' could not be found (are you missing a using directive or an assembly reference?) [/home/hawken/git/plugins-1-todo/jellyfin-plugin-channels/MediaBrowser.Channels.iPlayer/MediaBrowser.Channels.iPlayer.csproj]
LeagueOfLegendsChannel.cs(136,39): error CS0246: The type or namespace name 'ChannelMediaInfo' could not be found (are you missing a using directive or an assembly reference?) [/home/hawken/git/plugins-1-todo/jellyfin-plugin-channels/MediaBrowser.Channels.LeagueOfLegends/MediaBrowser.Channels.LeagueOfLegends.csproj]
LeagueOfLegendsChannel.cs(146,40): error CS0246: The type or namespace name 'ChannelMediaInfo' could not be found (are you missing a using directive or an assembly reference?) [/home/hawken/git/plugins-1-todo/jellyfin-plugin-channels/MediaBrowser.Channels.LeagueOfLegends/MediaBrowser.Channels.LeagueOfLegends.csproj]
LeagueOfLegendsChannel.cs(163,40): error CS0246: The type or namespace name 'ChannelMediaInfo' could not be found (are you missing a using directive or an assembly reference?) [/home/hawken/git/plugins-1-todo/jellyfin-plugin-channels/MediaBrowser.Channels.LeagueOfLegends/MediaBrowser.Channels.LeagueOfLegends.csproj]
LeagueOfLegendsChannel.cs(174,24): error CS0246: The type or namespace name 'ChannelMediaInfo' could not be found (are you missing a using directive or an assembly reference?) [/home/hawken/git/plugins-1-todo/jellyfin-plugin-channels/MediaBrowser.Channels.LeagueOfLegends/MediaBrowser.Channels.LeagueOfLegends.csproj]
Channel.cs(284,39): error CS0246: The type or namespace name 'ChannelMediaInfo' could not be found (are you missing a using directive or an assembly reference?) [/home/hawken/git/plugins-1-todo/jellyfin-plugin-channels/MediaBrowser.Plugins.CNET-TV/MediaBrowser.Plugins.CNET-TV.csproj]
UStreamChannel.cs(180,39): error CS0246: The type or namespace name 'ChannelMediaInfo' could not be found (are you missing a using directive or an assembly reference?) [/home/hawken/git/plugins-1-todo/jellyfin-plugin-channels/MediaBrowser.Plugins.UStream/MediaBrowser.Plugins.UStream.csproj]
Channel.cs(383,39): error CS0246: The type or namespace name 'ChannelMediaInfo' could not be found (are you missing a using directive or an assembly reference?) [/home/hawken/git/plugins-1-todo/jellyfin-plugin-channels/MediaBrowser.Channels.Vevo/MediaBrowser.Channels.Vevo.csproj]
SvtPlayChannel.cs(247,39): error CS0246: The type or namespace name 'ChannelMediaInfo' could not be found (are you missing a using directive or an assembly reference?) [/home/hawken/git/plugins-1-todo/jellyfin-plugin-channels/MediaBrowser.Channels.SvtPlay/MediaBrowser.Channels.SvtPlay.csproj]
TwitchChannel.cs(120,39): error CS0246: The type or namespace name 'ChannelMediaInfo' could not be found (are you missing a using directive or an assembly reference?) [/home/hawken/git/plugins-1-todo/jellyfin-plugin-channels/MediaBrowser.Plugins.Twitch/MediaBrowser.Plugins.Twitch.csproj]
Channel.cs(225,39): error CS0246: The type or namespace name 'ChannelMediaInfo' could not be found (are you missing a using directive or an assembly reference?) [/home/hawken/git/plugins-1-todo/jellyfin-plugin-channels/MediaBrowser.Channels.Adult.RedTube/MediaBrowser.Channels.Adult.RedTube.csproj]
Channel.cs(267,39): error CS0246: The type or namespace name 'ChannelMediaInfo' could not be found (are you missing a using directive or an assembly reference?) [/home/hawken/git/plugins-1-todo/jellyfin-plugin-channels/MediaBrowser.Channels.CBS/MediaBrowser.Channels.CBS.csproj]
Channel.cs(338,39): error CS0246: The type or namespace name 'ChannelMediaInfo' could not be found (are you missing a using directive or an assembly reference?) [/home/hawken/git/plugins-1-todo/jellyfin-plugin-channels/MediaBrowser.Plugins.ITV/MediaBrowser.Plugins.ITV.csproj]
VimeoChannel.cs(385,39): error CS0246: The type or namespace name 'ChannelMediaInfo' could not be found (are you missing a using directive or an assembly reference?) [/home/hawken/git/plugins-1-todo/jellyfin-plugin-channels/MediaBrowser.Plugins.Vimeo/MediaBrowser.Plugins.Vimeo.csproj]
Channel.cs(177,39): error CS0246: The type or namespace name 'ChannelMediaInfo' could not be found (are you missing a using directive or an assembly reference?) [/home/hawken/git/plugins-1-todo/jellyfin-plugin-channels/MediaBrowser.Channels.Adult.Beeg/MediaBrowser.Channels.Adult.Beeg.csproj]
Channel.cs(145,49): error CS0246: The type or namespace name 'ChannelMediaInfo' could not be found (are you missing a using directive or an assembly reference?) [/home/hawken/git/plugins-1-todo/jellyfin-plugin-channels/MediaBrowser.Channels.Vine-co/MediaBrowser.Channels.Vine-co.csproj]
Channel.cs(147,33): error CS0246: The type or namespace name 'ChannelMediaInfo' could not be found (are you missing a using directive or an assembly reference?) [/home/hawken/git/plugins-1-todo/jellyfin-plugin-channels/MediaBrowser.Channels.Vine-co/MediaBrowser.Channels.Vine-co.csproj]
Channel.cs(165,33): error CS0246: The type or namespace name 'ChannelMediaInfo' could not be found (are you missing a using directive or an assembly reference?) [/home/hawken/git/plugins-1-todo/jellyfin-plugin-channels/MediaBrowser.Channels.Vine-co/MediaBrowser.Channels.Vine-co.csproj]
Channel.cs(219,49): error CS0246: The type or namespace name 'ChannelMediaInfo' could not be found (are you missing a using directive or an assembly reference?) [/home/hawken/git/plugins-1-todo/jellyfin-plugin-channels/MediaBrowser.Channels.Vine-co/MediaBrowser.Channels.Vine-co.csproj]
Channel.cs(221,33): error CS0246: The type or namespace name 'ChannelMediaInfo' could not be found (are you missing a using directive or an assembly reference?) [/home/hawken/git/plugins-1-todo/jellyfin-plugin-channels/MediaBrowser.Channels.Vine-co/MediaBrowser.Channels.Vine-co.csproj]
Providers/AP/TrailerProvider.cs(102,17): error CS0246: The type or namespace name 'ChannelMediaInfo' could not be found (are you missing a using directive or an assembly reference?) [/home/hawken/git/plugins-1-todo/jellyfin-plugin-channels/MediaBrowser.Plugins.Trailers/MediaBrowser.Plugins.Trailers.csproj]
Providers/HD/BaseProvider.cs(104,22): error CS0246: The type or namespace name 'ChannelMediaInfo' could not be found (are you missing a using directive or an assembly reference?) [/home/hawken/git/plugins-1-todo/jellyfin-plugin-channels/MediaBrowser.Plugins.Trailers/MediaBrowser.Plugins.Trailers.csproj]
Providers/GlobalBaseProvider.cs(35,46): error CS0246: The type or namespace name 'ChannelMediaInfo' could not be found (are you missing a using directive or an assembly reference?) [/home/hawken/git/plugins-1-todo/jellyfin-plugin-channels/MediaBrowser.Plugins.Trailers/MediaBrowser.Plugins.Trailers.csproj]
Providers/GlobalBaseProvider.cs(35,19): error CS0246: The type or namespace name 'ChannelMediaInfo' could not be found (are you missing a using directive or an assembly reference?) [/home/hawken/git/plugins-1-todo/jellyfin-plugin-channels/MediaBrowser.Plugins.Trailers/MediaBrowser.Plugins.Trailers.csproj]
Providers/ML/BaseProvider.cs(246,22): error CS0246: The type or namespace name 'ChannelMediaInfo' could not be found (are you missing a using directive or an assembly reference?) [/home/hawken/git/plugins-1-todo/jellyfin-plugin-channels/MediaBrowser.Plugins.Trailers/MediaBrowser.Plugins.Trailers.csproj]
TrailerChannel.cs(455,29): error CS0246: The type or namespace name 'ChannelMediaInfo' could not be found (are you missing a using directive or an assembly reference?) [/home/hawken/git/plugins-1-todo/jellyfin-plugin-channels/MediaBrowser.Plugins.Trailers/MediaBrowser.Plugins.Trailers.csproj]
TrailerChannel.cs(536,42): error CS0246: The type or namespace name 'ChannelMediaInfo' could not be found (are you missing a using directive or an assembly reference?) [/home/hawken/git/plugins-1-todo/jellyfin-plugin-channels/MediaBrowser.Plugins.Trailers/MediaBrowser.Plugins.Trailers.csproj]

IRequiresMediaInfoCallback.GetChannelItemMediaInfo:

Channel.cs(24,38): error CS0738: 'Channel' does not implement interface member 'IRequiresMediaInfoCallback.GetChannelItemMediaInfo(string, CancellationToken)'. 'Channel.GetChannelItemMediaInfo(string, CancellationToken)' cannot implement 'IRequiresMediaInfoCallback.GetChannelItemMediaInfo(string, CancellationToken)' because it does not have the matching return type of 'Task<IEnumerable<MediaSourceInfo>>'. [/home/hawken/git/plugins-1-todo/jellyfin-plugin-channels/MediaBrowser.Channels.iPlayer/MediaBrowser.Channels.iPlayer.csproj]
LeagueOfLegendsChannel.cs(21,53): error CS0738: 'LeagueOfLegendsChannel' does not implement interface member 'IRequiresMediaInfoCallback.GetChannelItemMediaInfo(string, CancellationToken)'. 'LeagueOfLegendsChannel.GetChannelItemMediaInfo(string, CancellationToken)' cannot implement 'IRequiresMediaInfoCallback.GetChannelItemMediaInfo(string, CancellationToken)' because it does not have the matching return type of 'Task<IEnumerable<MediaSourceInfo>>'. [/home/hawken/git/plugins-1-todo/jellyfin-plugin-channels/MediaBrowser.Channels.LeagueOfLegends/MediaBrowser.Channels.LeagueOfLegends.csproj]
Channel.cs(20,38): error CS0738: 'Channel' does not implement interface member 'IRequiresMediaInfoCallback.GetChannelItemMediaInfo(string, CancellationToken)'. 'Channel.GetChannelItemMediaInfo(string, CancellationToken)' cannot implement 'IRequiresMediaInfoCallback.GetChannelItemMediaInfo(string, CancellationToken)' because it does not have the matching return type of 'Task<IEnumerable<MediaSourceInfo>>'. [/home/hawken/git/plugins-1-todo/jellyfin-plugin-channels/MediaBrowser.Plugins.CNET-TV/MediaBrowser.Plugins.CNET-TV.csproj]
UStreamChannel.cs(20,45): error CS0738: 'UStreamChannel' does not implement interface member 'IRequiresMediaInfoCallback.GetChannelItemMediaInfo(string, CancellationToken)'. 'UStreamChannel.GetChannelItemMediaInfo(string, CancellationToken)' cannot implement 'IRequiresMediaInfoCallback.GetChannelItemMediaInfo(string, CancellationToken)' because it does not have the matching return type of 'Task<IEnumerable<MediaSourceInfo>>'. [/home/hawken/git/plugins-1-todo/jellyfin-plugin-channels/MediaBrowser.Plugins.UStream/MediaBrowser.Plugins.UStream.csproj]
Channel.cs(20,38): error CS0738: 'Channel' does not implement interface member 'IRequiresMediaInfoCallback.GetChannelItemMediaInfo(string, CancellationToken)'. 'Channel.GetChannelItemMediaInfo(string, CancellationToken)' cannot implement 'IRequiresMediaInfoCallback.GetChannelItemMediaInfo(string, CancellationToken)' because it does not have the matching return type of 'Task<IEnumerable<MediaSourceInfo>>'. [/home/hawken/git/plugins-1-todo/jellyfin-plugin-channels/MediaBrowser.Channels.Vevo/MediaBrowser.Channels.Vevo.csproj]
SvtPlayChannel.cs(20,45): error CS0738: 'SvtPlayChannel' does not implement interface member 'IRequiresMediaInfoCallback.GetChannelItemMediaInfo(string, CancellationToken)'. 'SvtPlayChannel.GetChannelItemMediaInfo(string, CancellationToken)' cannot implement 'IRequiresMediaInfoCallback.GetChannelItemMediaInfo(string, CancellationToken)' because it does not have the matching return type of 'Task<IEnumerable<MediaSourceInfo>>'. [/home/hawken/git/plugins-1-todo/jellyfin-plugin-channels/MediaBrowser.Channels.SvtPlay/MediaBrowser.Channels.SvtPlay.csproj]
TwitchChannel.cs(22,44): error CS0738: 'TwitchChannel' does not implement interface member 'IRequiresMediaInfoCallback.GetChannelItemMediaInfo(string, CancellationToken)'. 'TwitchChannel.GetChannelItemMediaInfo(string, CancellationToken)' cannot implement 'IRequiresMediaInfoCallback.GetChannelItemMediaInfo(string, CancellationToken)' because it does not have the matching return type of 'Task<IEnumerable<MediaSourceInfo>>'. [/home/hawken/git/plugins-1-todo/jellyfin-plugin-channels/MediaBrowser.Plugins.Twitch/MediaBrowser.Plugins.Twitch.csproj]
Channel.cs(23,38): error CS0738: 'Channel' does not implement interface member 'IRequiresMediaInfoCallback.GetChannelItemMediaInfo(string, CancellationToken)'. 'Channel.GetChannelItemMediaInfo(string, CancellationToken)' cannot implement 'IRequiresMediaInfoCallback.GetChannelItemMediaInfo(string, CancellationToken)' because it does not have the matching return type of 'Task<IEnumerable<MediaSourceInfo>>'. [/home/hawken/git/plugins-1-todo/jellyfin-plugin-channels/MediaBrowser.Channels.Adult.RedTube/MediaBrowser.Channels.Adult.RedTube.csproj]
Channel.cs(22,38): error CS0738: 'Channel' does not implement interface member 'IRequiresMediaInfoCallback.GetChannelItemMediaInfo(string, CancellationToken)'. 'Channel.GetChannelItemMediaInfo(string, CancellationToken)' cannot implement 'IRequiresMediaInfoCallback.GetChannelItemMediaInfo(string, CancellationToken)' because it does not have the matching return type of 'Task<IEnumerable<MediaSourceInfo>>'. [/home/hawken/git/plugins-1-todo/jellyfin-plugin-channels/MediaBrowser.Channels.CBS/MediaBrowser.Channels.CBS.csproj]
Channel.cs(24,38): error CS0738: 'Channel' does not implement interface member 'IRequiresMediaInfoCallback.GetChannelItemMediaInfo(string, CancellationToken)'. 'Channel.GetChannelItemMediaInfo(string, CancellationToken)' cannot implement 'IRequiresMediaInfoCallback.GetChannelItemMediaInfo(string, CancellationToken)' because it does not have the matching return type of 'Task<IEnumerable<MediaSourceInfo>>'. [/home/hawken/git/plugins-1-todo/jellyfin-plugin-channels/MediaBrowser.Plugins.ITV/MediaBrowser.Plugins.ITV.csproj]
VimeoChannel.cs(20,43): error CS0738: 'VimeoChannel' does not implement interface member 'IRequiresMediaInfoCallback.GetChannelItemMediaInfo(string, CancellationToken)'. 'VimeoChannel.GetChannelItemMediaInfo(string, CancellationToken)' cannot implement 'IRequiresMediaInfoCallback.GetChannelItemMediaInfo(string, CancellationToken)' because it does not have the matching return type of 'Task<IEnumerable<MediaSourceInfo>>'. [/home/hawken/git/plugins-1-todo/jellyfin-plugin-channels/MediaBrowser.Plugins.Vimeo/MediaBrowser.Plugins.Vimeo.csproj]
Channel.cs(22,38): error CS0738: 'Channel' does not implement interface member 'IRequiresMediaInfoCallback.GetChannelItemMediaInfo(string, CancellationToken)'. 'Channel.GetChannelItemMediaInfo(string, CancellationToken)' cannot implement 'IRequiresMediaInfoCallback.GetChannelItemMediaInfo(string, CancellationToken)' because it does not have the matching return type of 'Task<IEnumerable<MediaSourceInfo>>'. [/home/hawken/git/plugins-1-todo/jellyfin-plugin-channels/MediaBrowser.Channels.Adult.Beeg/MediaBrowser.Channels.Adult.Beeg.csproj]

RunAsync:

EntryPoint.cs(5,31): error CS0535: 'EntryPoint' does not implement interface member 'IServerEntryPoint.RunAsync()' [/home/hawken/git/plugins-1-todo/jellyfin-plugin-channels/MediaBrowser.Plugins.Vimeo/MediaBrowser.Plugins.Vimeo.csproj]
EntryPoint.cs(5,31): error CS0535: 'EntryPoint' does not implement interface member 'IServerEntryPoint.RunAsync()' [/home/hawken/git/plugins-1-todo/jellyfin-plugin-channels/MediaBrowser.Plugins.SoundCloud/MediaBrowser.Plugins.SoundCloud.csproj]
EntryPoint.cs(13,31): error CS0535: 'EntryPoint' does not implement interface member 'IServerEntryPoint.RunAsync()' [/home/hawken/git/plugins-1-todo/jellyfin-plugin-channels/MediaBrowser.Plugins.Trailers/MediaBrowser.Plugins.Trailers.csproj]

IEncryptionManager:

Plugin.cs(41,13): error CS0246: The type or namespace name 'IEncryptionManager' could not be found (are you missing a using directive or an assembly reference?) [/home/hawken/git/plugins-1-todo/jellyfin-plugin-channels/MediaBrowser.Plugins.SoundCloud/MediaBrowser.Plugins.SoundCloud.csproj]
Plugin.cs(27,26): error CS0246: The type or namespace name 'IEncryptionManager' could not be found (are you missing a using directive or an assembly reference?) [/home/hawken/git/plugins-1-todo/jellyfin-plugin-channels/MediaBrowser.Plugins.SoundCloud/MediaBrowser.Plugins.SoundCloud.csproj]

IIndexableChannel:

TrailerChannel.cs(23,45): error CS0246: The type or namespace name 'IIndexableChannel' could not be found (are you missing a using directive or an assembly reference?) [/home/hawken/git/plugins-1-todo/jellyfin-plugin-channels/MediaBrowser.Plugins.Trailers/MediaBrowser.Plugins.Trailers.csproj]

InternalAllChannelMediaQuery:

TrailerChannel.cs(797,58): error CS0246: The type or namespace name 'InternalAllChannelMediaQuery' could not be found (are you missing a using directive or an assembly reference?) [/home/hawken/git/plugins-1-todo/jellyfin-plugin-channels/MediaBrowser.Plugins.Trailers/MediaBrowser.Plugins.Trailers.csproj]

Image stuff:

ImageProcessing/SoundCloudOverlayEnhancer.cs(135,99): error CS0246: The type or namespace name 'ImageSize' could not be found (are you missing a using directive or an assembly reference?) [/home/hawken/git/plugins-1-todo/jellyfin-plugin-channels/MediaBrowser.Plugins.SoundCloud/MediaBrowser.Plugins.SoundCloud.csproj]
ImageProcessing/SoundCloudOverlayEnhancer.cs(135,16): error CS0246: The type or namespace name 'ImageSize' could not be found (are you missing a using directive or an assembly reference?) [/home/hawken/git/plugins-1-todo/jellyfin-plugin-channels/MediaBrowser.Plugins.SoundCloud/MediaBrowser.Plugins.SoundCloud.csproj]
ImageProcessing/SoundCloudOverlayEnhancer.cs(217,29): error CS0246: The type or namespace name 'ImageSize' could not be found (are you missing a using directive or an assembly reference?) [/home/hawken/git/plugins-1-todo/jellyfin-plugin-channels/MediaBrowser.Plugins.SoundCloud/MediaBrowser.Plugins.SoundCloud.csproj]
ImageProcessing/SoundCloudOverlayEnhancer.cs(26,46): error CS0535: 'SoundCloudOverlayEnhancer' does not implement interface member 'IImageEnhancer.GetEnhancedImageSize(BaseItem, ImageType, int, ImageDimensions)' [/home/hawken/git/plugins-1-todo/jellyfin-plugin-channels/MediaBrowser.Plugins.SoundCloud/MediaBrowser.Plugins.SoundCloud.csproj]
ImageProcessing/SoundCloudOverlayEnhancer.cs(26,46): error CS0535: 'SoundCloudOverlayEnhancer' does not implement interface member 'IImageEnhancer.GetEnhancedImageInfo(BaseItem, string, ImageType, int)' [/home/hawken/git/plugins-1-todo/jellyfin-plugin-channels/MediaBrowser.Plugins.SoundCloud/MediaBrowser.Plugins.SoundCloud.csproj]

jellyfin-archive / emby-plugin-channels

WIP: Jellyfin port #1