search

jellyfin-archive / jellyfin-android-original

Android Client for Jellyfin
https://jellyfin.org
GNU General Public License v2.0
272 stars 65 forks source link

Add External player option #186

Closed grafixeyehero closed 5 years ago

thornbill commented 5 years ago

What does enabling this actually do? lol

grafixeyehero commented 5 years ago

@thornbill https://github.com/jellyfin/jellyfin-web/blob/a4dabc1644ac3e4f0b242a5760698e658c91fcda/src/components/playbacksettings/playbacksettings.js#L171 but the cordova externalplayer.js not fully implemented. but the visual look like this Screenshot (17)

thornbill commented 5 years ago

Oh I see so this change will enable the feature in web, but we will need additional changes on the Android side to get it working.