jellyfin-archive / jellyfin-android-original

Android Client for Jellyfin
https://jellyfin.org
GNU General Public License v2.0
271 stars 65 forks source link

android app cant control chromecast #198

Closed Luxtech closed 5 years ago

Luxtech commented 5 years ago

Screenshot_20190819-210638

I installed the jellyfin app from the playstore. And streaming media to my chromecast works fine. But after I started streaming I cant control the chromecast anymore. See the attached picture for more detail.

thornbill commented 5 years ago

There was another report of this issue on Reddit. https://www.reddit.com/r/jellyfin/comments/cuxaux/playback_control_android/ey0hau8/

stijnos1991 commented 5 years ago

Same for me. Fresh install (10.3.7) Samsung S8, Android 9. Patches up to july 1, 2019.

anthonylavado commented 5 years ago

Just as a temporary workaround, what happens if you "reconnect" to the Chromecast by clicking on the cast button at the top?

stijnos1991 commented 5 years ago

Unfortunately that doesn't work. Also, the only option to stop a video from playing on TV (launched by Chromecast) is to disconnect from the Chromecast.

nichobi commented 5 years ago

In my experience this happens whenever an episode of a series has a non-alphanumeric character in the title (usually '). Anyone else able to confirm?

tiberiusbrown commented 5 years ago

In my experience this happens whenever an episode of a series has a non-alphanumeric character in the title (usually '). Anyone else able to confirm?

My experience is similar to @nichobi. Remote controls do not appear for titles that contain a single-quote character, and this also occurs with TV episodes where the series title contains a single-quote, even if the episode title does not.

Update: seems to be caused by the metadata title, not the filename of the source video. For example, Harry Potter and the Sorcerers Stone (2001).mp4 does not show remote controls, seemingly because its metadata title contains the single-quote character, while Harry Potter and the Chamber of Secrets (2002).mp4 shows the controls correctly.

anthonylavado commented 5 years ago

Something about this line is broken in the Android app, as this doesn't appear to be an issue when using the web client: https://github.com/jellyfin/jellyfin-web/blob/a4dabc1644ac3e4f0b242a5760698e658c91fcda/src/components/chromecast/chromecastplayer.js#L557

Edit:

https://github.com/jellyfin/jellyfin-chromecast/blob/ff9253f5c4ae235e701b76aff54fb5e8926e7648/app.js#L36

cvium commented 5 years ago

To expand on @anthonylavado's edit. This line https://github.com/jellyfin/jellyfin-chromecast/blob/master/app.js#L36 should probably be changed to

    window.playlistMessageBus.broadcast(JSON.stringify(msg));
anthonylavado commented 5 years ago

I'll try this on the beta Chromecast app tonight.

anthonylavado commented 5 years ago

Is this the source of the issue?

https://github.com/jellyfin/cordova-plugin-chromecast/blob/c1ba3e7b25ca1097efb21bef0baf19b0d6801971/src/android/Chromecast.java#L809

anthonylavado commented 5 years ago

Sorry to move this issue around so much. Anyway, a new version of the app is available on the Google Play Store/in our repository, and it now includes a fix for this.

I’ve tested it personally and it has worked for me, so please try it and let us know if it works for you.

Luxtech commented 5 years ago

Thanks for the help, I updated the app and everything is fixed. I have full control over the chromecast!