jellyfin-archive / jellyfin-android-original

Android Client for Jellyfin
https://jellyfin.org
GNU General Public License v2.0
271 stars 65 forks source link

src code does not get updated when modified #236

Closed Stampede10343 closed 4 years ago

Stampede10343 commented 4 years ago

Not sure if I have the wrong workflow, but I'm trying to work on the native player but my changes don't get propagated until I completely delete all ignored directories that get generated by Cordova by doing git clean -dfX.

Is there a better workflow? Especially because Android Studio isn't really happy with working on the source outside of the normal app/src setup. And working on the cordova generated code isn't really possible since that all is ignored by git.

dkanada commented 4 years ago

I don't know of one, especially if you want to use the debugging functionality in Android Studio. @thornbill might know more, but this is definitely a huge pain to deal with.

Stampede10343 commented 4 years ago

The link command looks sorta like what we would want, but I'll have to give it a try.

But I'm mostly just trying to write some code and have it get built and run without having to delete the entire working directory.

Rijul-A commented 4 years ago

I briefly mentioned this issue in #200 but we didn't work on figuring out why this happens.

Stampede10343 commented 4 years ago

I figured it out. Might be worth throwing in the readme, basically just run

npx cordova plugins rm org.jellyfin.mobile

Then npx cordova plugins add src/NativeShell --link Then you can do the rest of the initial project setup and it hardlinks the code so when you change it under platforms/ it propagates to the actual src.