jellyfin-archive / jellyfin-android-original

Android Client for Jellyfin
https://jellyfin.org
GNU General Public License v2.0
271 stars 65 forks source link

Share button does nothing #293

Open Nazar78 opened 4 years ago

Nazar78 commented 4 years ago

Hi,

The share button doesn't seems to be working. Nothing happen when pressed. This is on Android 10, Samsung S9 plus.

thornbill commented 4 years ago

I had looked into fixing this at one point, but the current share implementation didn't seem useful at all. What would you expect to happen when you share content?

dkanada commented 4 years ago

I would expect a temporary sharing link that can be limited by clicks or time, but this feature has already been requested.

thornbill commented 4 years ago

For reference, the current implementation just shares the title, description, and a link to Jellyfin's website...

Nazar78 commented 4 years ago

For reference, the current implementation just shares the title, description, and a link to Jellyfin's website...

This was what I expected similar to the ones shared from mobile web, also as stated in the user's profile settings. Copy & paste is not an option here so does the web.

But to be able to share the actual media webpage would be cool too 😉 of course with some sort of permission/limits or have all the media functions removed for that page unless the session is authenticated.

nsvir commented 4 years ago

Caught the log error: TypeError: navigator.share is not a function

04-05 16:21:29.748  7082  7082 D SystemWebChromeClient: file:///android_asset/www/components/itemcontextmenu.js?v=5: Line 442 : Uncaught (in promise) TypeError: navigator.share is not a func
tion
04-05 16:21:29.748  7082  7082 I chromium: [INFO:CONSOLE(442)] "Uncaught (in promise) TypeError: navigator.share is not a function", source: file:///android_asset/www/components/itemcontextm
enu.js?v=5 (442)

With the behavior explained by @thornbill

case "share":
  navigator.share({
    title: item.Name,
    text: item.Overview,
    url: "https://github.com/jellyfin/jellyfin"
  });
  break;
millallo commented 4 years ago

If the app is showing a photo, I think the right action should be the sharing of the photo content

iot-resister commented 4 years ago

For reference, the current implementation just shares the title, description, and a link to Jellyfin's website...

Can we get a streaming link? So we can cast it using third party (non-google) apps like raspicast? The server already provides this.